Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reindex in Entity.query_by_values #626

Merged
merged 9 commits into from Jun 27, 2019

Conversation

Projects
None yet
2 participants
@CJStadler
Copy link
Contributor

commented Jun 25, 2019

reindex may change the order of the dataframe, but the dataframe
should keep the existing ordering by time index.

After calculating features call reindex to order by instance_ids.

Remove reindex in filter_by_values
Reindex may change the order, and features may assume that the dataframe
is ordered by time index.

After calculating features reindex to use order of instance_ids.
@codecov

This comment has been minimized.

Copy link

commented Jun 25, 2019

Codecov Report

Merging #626 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #626      +/-   ##
==========================================
+ Coverage   97.42%   97.43%   +<.01%     
==========================================
  Files         118      118              
  Lines        9532     9543      +11     
==========================================
+ Hits         9287     9298      +11     
  Misses        245      245
Impacted Files Coverage Δ
...mputational_backend/test_feature_set_calculator.py 100% <100%> (ø) ⬆️
featuretools/entityset/entity.py 96.49% <100%> (-0.02%) ⬇️
...s/computational_backends/feature_set_calculator.py 98.12% <100%> (+0.01%) ⬆️
...imitive_tests/test_groupby_transform_primitives.py 100% <100%> (ø) ⬆️
featuretools/tests/entityset_tests/test_entity.py 100% <100%> (ø) ⬆️
...s/tests/primitive_tests/test_transform_features.py 98.37% <100%> (ø) ⬆️
...ools/tests/primitive_tests/test_direct_features.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7fb459...cd2db12. Read the comment docs.

CJStadler added some commits Jun 26, 2019

Reset dtype instead of casting to list
This is faster and doesn't change the type.

The function can no longer accept lists, so update the tests to pass in
np.ndarray.
Merge branch 'cfm-always-sorted-by-time' of github.com:Featuretools/f…
…eaturetools into cfm-always-sorted-by-time
@kmax12

kmax12 approved these changes Jun 27, 2019

@CJStadler CJStadler merged commit c5f9e53 into master Jun 27, 2019

4 checks passed

codecov/patch 100% of diff hit (target 97.42%)
Details
codecov/project 97.43% (+<.01%) compared to f7fb459
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@CJStadler CJStadler deleted the cfm-always-sorted-by-time branch Jun 27, 2019

@rwedge rwedge referenced this pull request Jul 3, 2019

Merged

v0.9.1 #640

johnnyheineken pushed a commit to johnnyheineken/featuretools that referenced this pull request Jul 7, 2019

Remove reindex in Entity.query_by_values (Featuretools#626)
Reindex could change the order, violating the invariant that the dataframe
is ordered by time index.

After calculating features reindex to use order of instance_ids.

FeatureSetCalculator.run can no longer accept lists, so this updates the tests
to pass in np.ndarray.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.