Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed DaysSince primitive #628

Merged
merged 3 commits into from Jun 27, 2019

Conversation

Projects
None yet
3 participants
@kkleidal
Copy link
Contributor

commented Jun 26, 2019

Pull Request Description

Fixes #605

According to #605 , DaysSince is made obsolete by TimeSince, since DaysSince is equivalent to TimeSince(unit="days"). This patch removes the obsolete DaysSince primitive


After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

@CLAassistant

This comment has been minimized.

Copy link

commented Jun 26, 2019

CLA assistant check
All committers have signed the CLA.

@kkleidal

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2019

I can rebase down to one commit if that is standard practice and desired by the maintainers. Also: thanks for the coffee @kmax12

@codecov

This comment has been minimized.

Copy link

commented Jun 26, 2019

Codecov Report

Merging #628 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #628      +/-   ##
==========================================
- Coverage   97.43%   97.43%   -0.01%     
==========================================
  Files         118      118              
  Lines        9543     9534       -9     
==========================================
- Hits         9298     9289       -9     
  Misses        245      245
Impacted Files Coverage Δ
...retools/primitives/standard/transform_primitive.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5f9e53...5cf16a0. Read the comment docs.

@kmax12 kmax12 requested a review from CJStadler Jun 27, 2019

@CJStadler
Copy link
Contributor

left a comment

LGTM!

Thanks for the contribution @kkleidal. You can squash when you merge.

@kkleidal

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2019

Thanks @CJStadler . To which branch do you mean I should merge?

@CJStadler CJStadler merged commit 0257f52 into Featuretools:master Jun 27, 2019

3 of 4 checks passed

codecov/project 97.43% (-0.01%) compared to c5f9e53
Details
codecov/patch Coverage not affected when comparing c5f9e53...5cf16a0
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details
@CJStadler

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2019

Sorry @kkleidal, I didn't realize you couldn't merge to master. Thanks again!

@rwedge rwedge referenced this pull request Jul 3, 2019

Merged

v0.9.1 #640

johnnyheineken pushed a commit to johnnyheineken/featuretools that referenced this pull request Jul 7, 2019

Removed DaysSince primitive (Featuretools#628)
Since it is made obsolete by TimeSince. Fixes Featuretools#605
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.