Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cumulative primitives to docs #632

Merged
merged 3 commits into from Jul 3, 2019

Conversation

Projects
None yet
2 participants
@CJStadler
Copy link
Contributor

commented Jul 1, 2019

These seem to be missing.

@@ -156,6 +156,11 @@ Cumulative Transform Primitives

Diff
TimeSincePrevious

This comment has been minimized.

Copy link
@CJStadler

CJStadler Jul 1, 2019

Author Contributor

Do the above two belong under "Cumulative Transform Primitives"?

This comment has been minimized.

Copy link
@kmax12

kmax12 Jul 3, 2019

Member

that's the best place to put them for now since they do use multiple rows of the dataframe, although in this case just the previous

@codecov

This comment has been minimized.

Copy link

commented Jul 1, 2019

Codecov Report

Merging #632 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #632   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files         118      118           
  Lines        9535     9535           
=======================================
  Hits         9290     9290           
  Misses        245      245

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7203f2d...25d03d1. Read the comment docs.

@kmax12

kmax12 approved these changes Jul 3, 2019

@@ -156,6 +156,11 @@ Cumulative Transform Primitives

Diff
TimeSincePrevious

This comment has been minimized.

Copy link
@kmax12

kmax12 Jul 3, 2019

Member

that's the best place to put them for now since they do use multiple rows of the dataframe, although in this case just the previous

@CJStadler CJStadler merged commit e67fe58 into master Jul 3, 2019

4 checks passed

codecov/patch Coverage not affected when comparing 7203f2d...25d03d1
Details
codecov/project 97.43% remains the same compared to 7203f2d
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@CJStadler CJStadler deleted the cumulative-docs branch Jul 3, 2019

@rwedge rwedge referenced this pull request Jul 3, 2019

Merged

v0.9.1 #640

johnnyheineken pushed a commit to johnnyheineken/featuretools that referenced this pull request Jul 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.