Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Future Release section to changelog #641

Merged
merged 3 commits into from Jul 3, 2019

Conversation

@rwedge
Copy link
Contributor

commented Jul 3, 2019

Pull Request Description

New Future Release section for next development cycle


After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

rwedge added 3 commits Jul 3, 2019
@codecov

This comment has been minimized.

Copy link

commented Jul 3, 2019

Codecov Report

Merging #641 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #641   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files         118      118           
  Lines        9535     9535           
=======================================
  Hits         9290     9290           
  Misses        245      245

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7adfde...e4ba086. Read the comment docs.

@rwedge rwedge requested review from kmax12 and gsheni Jul 3, 2019

* Documentation Changes
* Miscellaneous changes (:pr:`641`)
* Testing Changes
* Miscellaneous changes ()

This comment has been minimized.

Copy link
@gsheni

gsheni Jul 3, 2019

Member

No PR number?

This comment has been minimized.

Copy link
@rwedge

rwedge Jul 3, 2019

Author Contributor

I left the Miscellaneous there since normal testing changes should be recorded there

If we don't have any this dev cycle I'll remove it in the release PR

@gsheni
gsheni approved these changes Jul 3, 2019
Copy link
Member

left a comment

looks good besides the 1 question

@kmax12
kmax12 approved these changes Jul 3, 2019

@rwedge rwedge merged commit 32d4b22 into master Jul 3, 2019

4 checks passed

codecov/patch Coverage not affected when comparing f7adfde...e4ba086
Details
codecov/project 97.43% remains the same compared to f7adfde
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@rwedge rwedge deleted the future-release-changelog-0-9-1 branch Jul 3, 2019

johnnyheineken pushed a commit to johnnyheineken/featuretools that referenced this pull request Jul 7, 2019
Add new Future Release section to changelog (Featuretools#641)
* Add new Future Release section to changelog

* update changelog

* add self as contributor
@rwedge rwedge referenced this pull request Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.