Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

top_n doctring modified to int #648

Merged
merged 8 commits into from Jul 8, 2019

Conversation

@ayushpatidar
Copy link
Contributor

commented Jul 8, 2019

Pull Request Description

The docstring in previous codebase says top_n type as dataframe.
In this pull request i have modified as int as the data type of top_n.

fixes #646


After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

ayushpatidar added 2 commits Jul 8, 2019
@CLAassistant

This comment has been minimized.

Copy link

commented Jul 8, 2019

CLA assistant check
All committers have signed the CLA.

@codecov

This comment has been minimized.

Copy link

commented Jul 8, 2019

Codecov Report

Merging #648 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #648   +/-   ##
=======================================
  Coverage   97.42%   97.42%           
=======================================
  Files         118      118           
  Lines        9539     9539           
=======================================
  Hits         9293     9293           
  Misses        246      246
Impacted Files Coverage Δ
featuretools/synthesis/encode_features.py 98.33% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4add6be...35a6daa. Read the comment docs.

@kmax12

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

@ayushpatidar can you update the changelog and sign the CLA? otherwise looks good to merge

ayushpatidar and others added 6 commits Jul 8, 2019
@kmax12
kmax12 approved these changes Jul 8, 2019
Copy link
Member

left a comment

Good to merge. Thanks!

@kmax12 kmax12 merged commit 8f4c5ca into Featuretools:master Jul 8, 2019

4 checks passed

codecov/patch Coverage not affected when comparing 4add6be...35a6daa
Details
codecov/project 97.42% remains the same compared to 4add6be
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details
@rwedge rwedge referenced this pull request Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.