Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlink ComposeML #653

Merged
merged 7 commits into from Jul 10, 2019

Conversation

@jeff-hernandez
Copy link
Collaborator

commented Jul 9, 2019

This PR will change docs by adding a hyperlink to ComposeML.


After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

@@ -10,4 +10,4 @@ If you would like to test `Feature Labs APIs <https://docs.featurelabs.com/>`_ f
Bring your own labels
*********************

If you are doing supervised machine learning, you must supply your own labels and cutoff times.
If you are doing supervised machine learning, you must supply your own labels and cutoff times. To automate this process, checkout `ComposeML <http://compose.ml>`_ which is an open source project for automatically generating labels with cutoff times.

This comment has been minimized.

Copy link
@kmax12

kmax12 Jul 9, 2019

Member

how about phrasing like this?

If you are doing supervised machine learning, you must supply your own labels and cutoff times. To structure this process, you can use ComposeML <http://compose.ml>_, which is an open source project for automatically generating labels with cutoff times.

This comment has been minimized.

Copy link
@jeff-hernandez

jeff-hernandez Jul 9, 2019

Author Collaborator

That works. Will make the update.

@codecov

This comment has been minimized.

Copy link

commented Jul 9, 2019

Codecov Report

Merging #653 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #653   +/-   ##
=======================================
  Coverage   97.42%   97.42%           
=======================================
  Files         118      118           
  Lines        9539     9539           
=======================================
  Hits         9293     9293           
  Misses        246      246

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ffbe9e...707da67. Read the comment docs.

@kmax12
Copy link
Member

left a comment

LGTM. Ready to merge!

@kmax12
kmax12 approved these changes Jul 10, 2019

@jeff-hernandez jeff-hernandez merged commit 0c8f506 into Featuretools:master Jul 10, 2019

4 checks passed

codecov/patch Coverage not affected when comparing 5ffbe9e...707da67
Details
codecov/project 97.42% remains the same compared to 5ffbe9e
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@jeff-hernandez jeff-hernandez deleted the jeff-hernandez:link-compose branch Jul 10, 2019

@rwedge rwedge referenced this pull request Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.