Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move exporting feature matrix example in docs #658

merged 11 commits into from Jul 15, 2019


Copy link

commented Jul 11, 2019

Doesn't need to be at the top level of the documentation and fits well within the deployment page

kmax12 added 2 commits Jul 11, 2019

This comment has been minimized.

Copy link

commented Jul 11, 2019

Codecov Report

Merging #658 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #658   +/-   ##
  Coverage   97.42%   97.42%           
  Files         118      118           
  Lines        9560     9560           
  Hits         9314     9314           
  Misses        246      246

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb86522...06ccfdf. Read the comment docs.

@kmax12 kmax12 requested a review from gsheni Jul 11, 2019

docs/source/changelog.rst Show resolved Hide resolved
@@ -9,7 +9,7 @@ Changelog
* Changes
* Moved dask, distributed imports (:pr:`634`)
* Documentation Changes
* Miscellaneous changes (:pr:`641`)
* Miscellaneous changes (:pr:`641`, :pr:`658`)
* Modified doc_string of top_n in encoding (:pr:`648`)
* Hyperlinked ComposeML (:pr:`653`)
* Testing Changes

This comment has been minimized.

Copy link

gsheni Jul 11, 2019


Missing user name 4 lines below

@kmax12 kmax12 changed the title Remove exporting feature matrix example from docs Move exporting feature matrix example in docs Jul 11, 2019


This comment has been minimized.

Copy link

commented Jul 11, 2019

Can you add yourself to the list of contributors?

kmax12 and others added 3 commits Jul 11, 2019
@@ -68,3 +68,29 @@ After we load the features back in, we can calculate the feature matrix.
As you can see above, we have the exact same features as before, but calculated on using our test data.

This comment has been minimized.

Copy link

rwedge Jul 11, 2019


"calculated on using our test data" sounds awkward

kmax12 added 3 commits Jul 14, 2019
rwedge approved these changes Jul 15, 2019

@kmax12 kmax12 merged commit 12dbb41 into master Jul 15, 2019

4 checks passed

codecov/patch Coverage not affected when comparing eb86522...06ccfdf
codecov/project 97.42% remains the same compared to eb86522
license/cla Contributor License Agreement is signed.
test_all_python_versions Workflow: test_all_python_versions
@rwedge rwedge referenced this pull request Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.