Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Trigger Test #660

Merged
merged 12 commits into from Jul 11, 2019

Conversation

@gsheni
Copy link
Member

commented Jul 11, 2019

No description provided.

gsheni added 3 commits Jul 11, 2019
@codecov

This comment has been minimized.

Copy link

commented Jul 11, 2019

Codecov Report

Merging #660 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #660   +/-   ##
=======================================
  Coverage   97.42%   97.42%           
=======================================
  Files         118      118           
  Lines        9539     9539           
=======================================
  Hits         9293     9293           
  Misses        246      246

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7206f7b...9dd5e52. Read the comment docs.

gsheni added 3 commits Jul 11, 2019

@gsheni gsheni self-assigned this Jul 11, 2019

@gsheni gsheni requested review from rwedge and kmax12 and removed request for rwedge Jul 11, 2019

@kmax12
Copy link
Member

left a comment

looks fine to me. although will defer to @rwedge since he know circleci better than i do

docs/source/changelog.rst Outdated Show resolved Hide resolved
gsheni added 5 commits Jul 11, 2019
@rwedge
rwedge approved these changes Jul 11, 2019
Copy link
Contributor

left a comment

Looks good

@gsheni gsheni merged commit a3966fa into master Jul 11, 2019

4 checks passed

codecov/patch Coverage not affected when comparing 7206f7b...9dd5e52
Details
codecov/project 97.42% remains the same compared to 7206f7b
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@gsheni gsheni deleted the add_pp_test branch Jul 11, 2019

@rwedge rwedge referenced this pull request Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.