Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use python 3.7.4 image on circleci #674

Merged
merged 4 commits into from Jul 19, 2019

Conversation

@rwedge
Copy link
Contributor

commented Jul 16, 2019

Pull Request Description

Branch testing compatibility with circleci's 3.7.4 docker image


After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

@codecov

This comment has been minimized.

Copy link

commented Jul 16, 2019

Codecov Report

Merging #674 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #674   +/-   ##
=======================================
  Coverage   97.44%   97.44%           
=======================================
  Files         118      118           
  Lines        9634     9634           
=======================================
  Hits         9388     9388           
  Misses        246      246

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2541666...48e7b42. Read the comment docs.

@rwedge rwedge changed the title [WIP] Use circleci 3.7 image tag Use python 3.7.4 image on circleci Jul 19, 2019

@rwedge rwedge requested a review from gsheni Jul 19, 2019

@gsheni
gsheni approved these changes Jul 19, 2019

@rwedge rwedge merged commit 1bc5f97 into master Jul 19, 2019

4 checks passed

codecov/patch Coverage not affected when comparing 2541666...48e7b42
Details
codecov/project 97.44% remains the same compared to 2541666
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@rwedge rwedge deleted the circleci-37-image-revert branch Jul 19, 2019

@rwedge rwedge referenced this pull request Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.