Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable types modify in Entity init #675

Merged
merged 5 commits into from Jul 17, 2019

Conversation

@gsheni
Copy link
Member

commented Jul 17, 2019

Fix variable types modify in Entity init

Fixes #671

@gsheni gsheni requested a review from rwedge Jul 17, 2019

@gsheni gsheni self-assigned this Jul 17, 2019

gsheni added 2 commits Jul 17, 2019
@codecov

This comment has been minimized.

Copy link

commented Jul 17, 2019

Codecov Report

Merging #675 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #675      +/-   ##
==========================================
+ Coverage   97.42%   97.42%   +<.01%     
==========================================
  Files         118      118              
  Lines        9560     9567       +7     
==========================================
+ Hits         9314     9321       +7     
  Misses        246      246
Impacted Files Coverage Δ
featuretools/tests/entityset_tests/test_entity.py 100% <100%> (ø) ⬆️
featuretools/entityset/entity.py 96.09% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ded4809...fb7f097. Read the comment docs.

featuretools/tests/entityset_tests/test_entity.py Outdated Show resolved Hide resolved
docs/source/changelog.rst Outdated Show resolved Hide resolved
@rwedge
rwedge approved these changes Jul 17, 2019

@gsheni gsheni merged commit e0e9802 into master Jul 17, 2019

4 checks passed

codecov/patch 100% of diff hit (target 97.42%)
Details
codecov/project 97.42% (+<.01%) compared to ded4809
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@gsheni gsheni deleted the vtypes_copy branch Jul 17, 2019

@rwedge rwedge referenced this pull request Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.