Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding categorical-encoding to setup.py #700

Merged
merged 9 commits into from Aug 16, 2019

Conversation

@alexjwang
Copy link
Contributor

commented Aug 7, 2019

Pull Request Description

Incorporating categorical-encoding PyPi library release into Featuretools.

alexjwang added 3 commits Aug 7, 2019
@codecov

This comment has been minimized.

Copy link

commented Aug 7, 2019

Codecov Report

Merging #700 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #700   +/-   ##
=======================================
  Coverage   97.64%   97.64%           
=======================================
  Files         118      118           
  Lines       10173    10173           
=======================================
  Hits         9933     9933           
  Misses        240      240

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bf7210...b7a87b4. Read the comment docs.

@kmax12 kmax12 self-requested a review Aug 7, 2019

@kmax12
Copy link
Member

left a comment

This is looks good, but let's hold off on merging for now.

@kmax12

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

@alexjwang can you also add to docs/source/getting_started/install.rst? look at how we do it in #699

alexjwang added 5 commits Aug 14, 2019
@kmax12
kmax12 approved these changes Aug 16, 2019

@alexjwang alexjwang merged commit 89c242f into master Aug 16, 2019

4 checks passed

codecov/patch Coverage not affected when comparing 0bf7210...b7a87b4
Details
codecov/project 97.64% remains the same compared to 0bf7210
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@alexjwang alexjwang deleted the categorical-encoding-library branch Aug 16, 2019

@rwedge rwedge referenced this pull request Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.