Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for nlp-primitives #704

Merged
merged 10 commits into from Aug 16, 2019

Conversation

@ctduffy
Copy link
Contributor

commented Aug 12, 2019

Pull Request Description

Incorporates the nlp-primitives PyPI library into Featuretools.

@codecov

This comment has been minimized.

Copy link

commented Aug 12, 2019

Codecov Report

Merging #704 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #704   +/-   ##
=======================================
  Coverage   97.64%   97.64%           
=======================================
  Files         118      118           
  Lines       10173    10173           
=======================================
  Hits         9933     9933           
  Misses        240      240

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d904f7b...18f77b3. Read the comment docs.

kmax12 and others added 3 commits Aug 14, 2019
@kmax12

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

@ctduffy can you also add to docs/source/getting_started/install.rst? look at how we do it in #699

@ctduffy

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2019

Add the nlp-primitives API doc to the Featuretools documentation, which will require putting nlp-primitives as a requirement in FT dev reqs

@ctduffy ctduffy requested a review from kmax12 Aug 16, 2019

@kmax12
kmax12 approved these changes Aug 16, 2019

@ctduffy ctduffy merged commit 0bf7210 into master Aug 16, 2019

4 checks passed

codecov/patch Coverage not affected when comparing d904f7b...18f77b3
Details
codecov/project 97.64% remains the same compared to d904f7b
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@ctduffy ctduffy deleted the nlp-prims branch Aug 16, 2019

@rwedge rwedge referenced this pull request Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.