New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `entity_from_csv`, tests, and lint #71

Merged
merged 2 commits into from Jan 23, 2018

Conversation

Projects
None yet
3 participants
@Seth-Rothschild
Contributor

Seth-Rothschild commented Jan 18, 2018

Removes entity_from_csv as discussed in #57

@codecov-io

This comment has been minimized.

codecov-io commented Jan 18, 2018

Codecov Report

Merging #71 into master will increase coverage by 0.43%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #71      +/-   ##
=========================================
+ Coverage   87.07%   87.5%   +0.43%     
=========================================
  Files          75      75              
  Lines        7186    7147      -39     
=========================================
- Hits         6257    6254       -3     
+ Misses        929     893      -36
Impacted Files Coverage Δ
utils/gen_utils.py 64.44% <0%> (-2.23%) ⬇️
tests/entityset_tests/test_pandas_es.py 99.71% <0%> (ø) ⬆️
tests/entityset_tests/test_es.py 95.65% <0%> (+2.79%) ⬆️
entityset/entityset.py 89.8% <0%> (+6.22%) ⬆️
demo/flight.py 35.48% <0%> (+6.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20fb59f...1a7fbc1. Read the comment docs.

@@ -4,7 +4,6 @@
from builtins import range, zip
from collections import defaultdict
import dask.dataframe as dd

This comment has been minimized.

@kmax12

kmax12 Jan 22, 2018

Member

can we remove dask as a dependency in featuretools now?

This comment has been minimized.

@Seth-Rothschild

Seth-Rothschild Jan 22, 2018

Contributor

Looks like it. The only other use is in load_flight which gets used in the approximate features docs page (but with a limit on the number of rows). We could just put a hard cap on the number of rows and then not require dask projectwide?

This comment has been minimized.

@kmax12

kmax12 Jan 22, 2018

Member

i think it's okay to have a dask as an optional requirement to run the demos. we just need to indicate that in the docstring of load_flight and add to the installation page that dask is an optional requirement for running demos.

we also need to put a try catch around the import of dask in the demo files to avoid errors if users don't have it.

@@ -299,7 +298,8 @@ def add_column(self, entity_id, column_id, column_data, type=None):
"""
Add variable to entity's dataframe
"""
self.entity_stores[entity_id].add_column(column_id, column_data, type=type)
self.entity_stores[entity_id].add_column(

This comment has been minimized.

@kmax12

kmax12 Jan 22, 2018

Member

can you undo your line length changes for now? We currently allow lines to go beyond 80 characters in special cases like this one and edits below

Seth-Rothschild

@Seth-Rothschild Seth-Rothschild force-pushed the remove_from_csv branch from 0dfe0c1 to 21629cd Jan 22, 2018

Seth-Rothschild
@kmax12

kmax12 approved these changes Jan 23, 2018

@kmax12

This comment has been minimized.

Member

kmax12 commented Jan 23, 2018

looks good to me!

@kmax12 kmax12 merged commit 9eac716 into master Jan 23, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge referenced this pull request Feb 27, 2018

Merged

Release v0.1.18 #102

@Seth-Rothschild Seth-Rothschild deleted the remove_from_csv branch Apr 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment