Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FAQ cell output #710

Merged
merged 6 commits into from Aug 25, 2019

Conversation

@gsheni
Copy link
Member

commented Aug 20, 2019

  • FAQ notebook had a cell that was run
    • The FAQ notebook + sphinx docs needs to have no output when committed. The sphinx docs will run all the cells in the notebook when it builds the docs. But the cells for FAQ notebook won't be run if 1 or more cells has previously ran (with a saved output in the notebook).
gsheni added 5 commits Aug 20, 2019
@codecov

This comment has been minimized.

Copy link

commented Aug 20, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@4bcb4ad). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #710   +/-   ##
=========================================
  Coverage          ?   97.63%           
=========================================
  Files             ?      118           
  Lines             ?    10177           
  Branches          ?        0           
=========================================
  Hits              ?     9936           
  Misses            ?      241           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bcb4ad...4c8c11b. Read the comment docs.

@gsheni gsheni self-assigned this Aug 23, 2019

@gsheni gsheni requested a review from kmax12 Aug 23, 2019

@kmax12
kmax12 approved these changes Aug 25, 2019
Copy link
Member

left a comment

Thanks! Merging

@kmax12 kmax12 merged commit e9b7f62 into master Aug 25, 2019

4 checks passed

codecov/patch Coverage not affected.
Details
codecov/project No report found to compare against
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@kmax12 kmax12 deleted the fix_faq branch Aug 25, 2019

@rwedge rwedge referenced this pull request Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.