Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change LatLong columns back into tuples when deserializing from csv or parquet #712

Merged
merged 10 commits into from Aug 25, 2019

Conversation

@rwedge
Copy link
Contributor

commented Aug 22, 2019

Pull Request Description

Fixes #691

Also fixes Dataframe.__eq__ converting all object columns in the dataframe to unicode strings.

@CJStadler did you encounter this with csv as well or just parquet?


After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

@codecov

This comment has been minimized.

Copy link

commented Aug 22, 2019

Codecov Report

Merging #712 into master will increase coverage by <.01%.
The diff coverage is 97.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #712      +/-   ##
==========================================
+ Coverage   97.63%   97.63%   +<.01%     
==========================================
  Files         118      118              
  Lines       10177    10201      +24     
==========================================
+ Hits         9936     9960      +24     
  Misses        241      241
Impacted Files Coverage Δ
featuretools/entityset/serialize.py 98.75% <100%> (+0.01%) ⬆️
...etools/tests/entityset_tests/test_serialization.py 97.98% <100%> (+0.06%) ⬆️
featuretools/tests/entityset_tests/test_entity.py 100% <100%> (ø) ⬆️
featuretools/entityset/deserialize.py 99.05% <100%> (+0.1%) ⬆️
featuretools/utils/wrangle.py 75.55% <92.3%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9b7f62...57bbb8b. Read the comment docs.

@rwedge rwedge requested a review from kmax12 Aug 22, 2019

if load_format in ['parquet', 'csv']:
latlongs = []
for var_description in description['variables']:
if var_description['type']['value'] == "latlong":

This comment has been minimized.

Copy link
@kmax12

kmax12 Aug 22, 2019

Member

perhaps use LatLong.type_string here instead of "latlong

@kmax12
Copy link
Member

left a comment

LGTM

@kmax12
kmax12 approved these changes Aug 25, 2019

@rwedge rwedge merged commit 19e6c3b into master Aug 25, 2019

4 checks passed

codecov/patch 97.67% of diff hit (target 97.63%)
Details
codecov/project 97.63% (+<.01%) compared to e9b7f62
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details

@rwedge rwedge deleted the deserialize_latlong branch Aug 25, 2019

@rwedge rwedge referenced this pull request Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.