New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed hash issue with same base features #8

Merged
merged 3 commits into from Oct 11, 2017

Conversation

Projects
None yet
3 participants
@gsheni
Contributor

gsheni commented Oct 11, 2017

if there is a feature which is the square of another feature, that would not be currently possible with our current feature primitive.

Feature(es["log"]["value"]) * Feature(es["log"]["value"])

So this fixes this by having the left and right point to the same element in base_features

@CLAassistant

This comment has been minimized.

CLAassistant commented Oct 11, 2017

CLA assistant check
All committers have signed the CLA.

@kmax12

This comment has been minimized.

Member

kmax12 commented Oct 11, 2017

can you add a test?

gsheni added some commits Oct 11, 2017

@kmax12

This comment has been minimized.

Member

kmax12 commented Oct 11, 2017

looks good to me

@kmax12 kmax12 merged commit 7cbb223 into master Oct 11, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@kmax12 kmax12 deleted the base_feat_fix branch Oct 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment