New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix related_instances() to respect time_last when instance_ids not provided #97

Merged
merged 1 commit into from Feb 20, 2018

Conversation

Projects
None yet
3 participants
@bschreck
Contributor

bschreck commented Feb 17, 2018

Resolves #93

@codecov-io

This comment has been minimized.

codecov-io commented Feb 17, 2018

Codecov Report

Merging #97 into master will increase coverage by 0.02%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
+ Coverage   87.62%   87.65%   +0.02%     
==========================================
  Files          73       73              
  Lines        7191     7192       +1     
==========================================
+ Hits         6301     6304       +3     
+ Misses        890      888       -2
Impacted Files Coverage Δ
...aturetools/tests/entityset_tests/test_pandas_es.py 99.72% <100%> (ø) ⬆️
featuretools/entityset/entityset.py 89.75% <80%> (-0.05%) ⬇️
featuretools/entityset/entity.py 77.48% <0%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98eab54...aa0b712. Read the comment docs.

@kmax12

This comment has been minimized.

Member

kmax12 commented Feb 20, 2018

good catch. merging

@kmax12 kmax12 closed this Feb 20, 2018

@kmax12 kmax12 reopened this Feb 20, 2018

@kmax12 kmax12 merged commit e6390c1 into master Feb 20, 2018

1 of 2 checks passed

ci/circleci CircleCI is running your tests
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge referenced this pull request Feb 27, 2018

Merged

Release v0.1.18 #102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment