Cannot add location when device's location mode is device only

[sjl872964789]

Describe the bug
The location cannot be added, and there are no explanations and reminders for the user. After investigation, I found that the problem is caused by the "device only" mode. Omni notes should prompt the user to switch the location mode just as it prompts the user to open the location. Otherwise, the user may not know why the location cannot be added

Context

• Device: galaxy a6s
• OS version: Android 8.1.0
• App version: 6.0.5

How to reproduce
Steps to reproduce the behavior:

1. Change location mode to "device only"
2. Install Omni Notes and open
3. Click on plus button in the lower right corner
4. Click on "Text note'
5. Click the paper clip button
6. Click on "Location'
7. See "LOCATION NOT FOUND"

Expected behavior
The user should be prompted that the current positioning mode cannot be located and needs to switch to high accuracy mode

Screenshots
Recorded video see attachment
record.zip

[federicoiosue]

First of all thanks for the great bug reporting!

I'll dig further into asap, meanwhile, when you say "device only" it means that you're using only GPS isn't it?

[sjl872964789]

Thank you for your kind reply. Yes, "device only" means that I'm using only GPS. There are two ways to make your device in "device only" location mode. The first way is to turn on location setting and turn off the network. The second way is to select "device only" mode through a special setting, which is available in my mobile phone(galaxy a6s-android8.1.0) and the Android simulator I often use (pixel2-android8.0). At this time, no matter whether your network is turned on or not, you can only use GPS for positioning. The way to turn on this setting is as follows:

[tingsu]

Simiar issue here. Any plan to resolve this problem? Thanks.

[sachin-0102]

Can I work on this issue?

[federicoiosue]

@sachin-0102 of course you can. Please give a look to README to follow code contribution guidelines!

[sachin-0102]

I've made a PR on this issue...Check it out and let me know if something needs improvement

[federicoiosue]

Fixed by #778 and 9388e24