Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outo backup #646

Closed
wants to merge 3 commits into from
Closed

outo backup #646

wants to merge 3 commits into from

Conversation

marwaothman
Copy link

@marwaothman marwaothman commented Dec 25, 2018

No description provided.

marwaothman added 3 commits Dec 23, 2018
auto backup
we have added auto backup
the app will ask user first if he want to auto backup,
if user click 'Yes' the feature is on.
Copy link
Owner

@federicoiosue federicoiosue left a comment

Hi @marwaothman,

thanks for your contribution but this code can't be merged for many reasons:

  1. Missing both unit and UI tests
  2. The whole code greatly increases technical debt due to a lot of thing, many of these are: code repetition, missing exception handling, hard-coded text strings, preferences management in main thread, commented code rows.

You could try to work on these things. Another thing that could help you could be to work on the specific feature branch (as stated into the README the approach is gitflow) called autobackup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants