Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix resorting from the data of version <= 5.5.2 #683

Closed
wants to merge 1 commit into from

Conversation

travellers
Copy link

@travellers travellers commented Jun 21, 2019

add 2 lines

@travellers
Copy link
Author

@travellers travellers commented Jun 21, 2019

......

@federicoiosue
Copy link
Owner

@federicoiosue federicoiosue commented Jun 27, 2019

A couple of questions:

  • What is the scenario solved by this patch?
  • Could you provide a test for this code change? Due to growing complexity of the app the the few time I can spend on its development whenever I add some changes I provide unit/integration/ui tests to avoid regression issues and prove that the code change solved or added something.

Thanks for your contribution!

@travellers
Copy link
Author

@travellers travellers commented Jul 7, 2019

Hi, Federicoiosue,
This commit is for issues reported at #653 and #678.
Before I committed, I have tested, and I will ask the related contributors to verify it more.
The commit only affect data restoring procedure.

Thanks very much for your project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Omni Notes
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants