Location Bug Fixed

[sachin-0102]

This should fix the issue of #764 as that setting was deprecated from api 28 and above, I've assigned the required fix

[federicoiosue]

Nice job!

Before merging your changes a couple of tests are needed: due to the fact that this code must work both for Play(Store, with Google's dependencies) and FOSS (F-Droid, without anything closed source being part of the compiling chain) would be nice to have a unit/android/ui test to ensure that no regression bugs are introduced, or that I'll never break your fix again in the future.

Would you be so kind to add them too? And feel free to add yourself to the CONTRIBUTORS.md file into the project root!

[sachin-0102]

I didn't quite catch that, what exactly do you want me to do?

[federicoiosue]

I'll elaborate a little too be as much complete as possible with my answer, but basically what I've asked you for is exactly what is stated into the README, in the "Test your code contributions!" section.

This project is actually my very first Android code.
So a lot of things are outdated (I try to keep the code updated with latest framework changes but it's not that much easy), many others are real spaghetti coding, for to my lack of experience at that time in clean coding.
As you can see by looking at both project board on GitHub or Sonarqube the most of my latest work has been done to reduce code debt and improve testing coverage to make the app more stable and help other developers to work on ON.

That's why whenever I find some bugs or implement new features covering that code with tests is very important.

[federicoiosue]

I'll elaborate a little too be as much complete as possible with my answer, but basically what I've asked you for is exactly what is stated into the README, in the "Test your code contributions!" section.

This project is actually my very first Android code.
So a lot of things are outdated (I try to keep the code updated with latest framework changes but it's not that much easy), many others are real spaghetti coding, for to my lack of experience at that time in clean coding.
As you can see by looking at both project board on GitHub or Sonarqube the most of my latest work has been done to reduce code debt and improve testing coverage to make the app more stable and help other developers to work on ON.

That's why whenever I find some bugs or implement new features covering that code with tests is very important.

[sachin-0102]

https://drive.google.com/file/d/1SwB_xf7Rv85u58uD5vetmYXgVW7oKaj9/view?usp=sharing

Please have a look at this video. I have also added a toast to tell the user what he's supposed to do.

[sachin-0102]

Do Note ! I haven't changed anything in the last two files. I was trying to understand the code and I deleted a statement by mistake. I have undone it but its still showing that something's changed. So i've checked it. Everything's working fine