-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Location Bug Fixed #778
Location Bug Fixed #778
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
Before merging your changes a couple of tests are needed: due to the fact that this code must work both for Play(Store, with Google's dependencies) and FOSS (F-Droid, without anything closed source being part of the compiling chain) would be nice to have a unit/android/ui test to ensure that no regression bugs are introduced, or that I'll never break your fix again in the future.
Would you be so kind to add them too? And feel free to add yourself to the CONTRIBUTORS.md file into the project root!
I didn't quite catch that, what exactly do you want me to do? |
I'll elaborate a little too be as much complete as possible with my answer, but basically what I've asked you for is exactly what is stated into the README, in the "Test your code contributions!" section. This project is actually my very first Android code. That's why whenever I find some bugs or implement new features covering that code with tests is very important. |
1 similar comment
I'll elaborate a little too be as much complete as possible with my answer, but basically what I've asked you for is exactly what is stated into the README, in the "Test your code contributions!" section. This project is actually my very first Android code. That's why whenever I find some bugs or implement new features covering that code with tests is very important. |
https://drive.google.com/file/d/1SwB_xf7Rv85u58uD5vetmYXgVW7oKaj9/view?usp=sharing Please have a look at this video. I have also added a toast to tell the user what he's supposed to do. |
Do Note ! I haven't changed anything in the last two files. I was trying to understand the code and I deleted a statement by mistake. I have undone it but its still showing that something's changed. So i've checked it. Everything's working fine |
This should fix the issue of #764 as that setting was deprecated from api 28 and above, I've assigned the required fix