log why buildroot overrides are expired

This lets us debug BROs unexpectedly getting untagged in Koji easier.

Fixes #3060

Signed-off-by: Nils Philippsen <nils@redhat.com>
(cherry picked from commit 759daf4)

bodhi/server/consumers/masher.py

@@ -642,6 +642,7 @@ def expire_buildroot_overrides(self):
                 for build in update.builds:
                     if build.override:
                         try:
+                            log.debug(f"Expiring BRO for {build.nvr} because it is being pushed.")
                             build.override.expire()
                         except Exception:
                             log.exception('Problem expiring override')

bodhi/server/models.py

@@ -2195,6 +2195,7 @@ def edit(cls, request, data):
 
                 # Expire any associated buildroot override
                 if b.override:
+                    log.debug(f"Expiring BRO for {b.nvr} because the build is unpushed.")
                     b.override.expire()
                 else:
                     # Only delete the Build entity if it isn't associated with
@@ -4459,6 +4460,7 @@ def new(cls, request, **data):
         if old_build is not None and old_build.override is not None:
             # There already is a buildroot override for an older build of this
             # package in this release. Expire it
+            log.debug(f"Expiring BRO for {old_build.nvr} because it's superseded by {build.nvr}.")
             old_build.override.expire()
             db.add(old_build.override)
 
@@ -4503,6 +4505,7 @@ def edit(cls, request, **data):
             override.enable()
 
         elif data['expired']:
+            log.debug(f"Expiring BRO for {override.build.nvr} because it was edited.")
             override.expire()
 
         db.add(override)

bodhi/server/scripts/expire_overrides.py

@@ -75,6 +75,7 @@ def main(argv=sys.argv):
         log.info("Expiring %d buildroot overrides...", count)
 
         for override in overrides:
+            log.debug(f"Expiring BRO for {override.build.nvr} because it's due to expire.")
             override.expire()
             db.add(override)
             log.info("Expired %s" % override.build.nvr)