Skip to content
Permalink
Browse files

(UI) Check taskotron checks per build, not update.

Taskotron records results on a per-build basis. We previously only queried for
results on a per-update basis, which meant that we missed a lot of the new
checks.

This change makes it so that we show them all.
  • Loading branch information...
ralphbean committed Aug 5, 2016
1 parent 8103a96 commit ce2394c60240d37d66d9c19f5f59d083b2865afa
Showing with 12 additions and 6 deletions.
  1. +4 −0 bodhi/models/models.py
  2. +8 −6 bodhi/templates/update.html
@@ -1680,6 +1680,10 @@ def check_karma_thresholds(self, db, agent):
log.debug('%s locked. Ignoring karma thresholds.' % self.title)
raise LockedUpdateException

@property
def builds_json(self):
return json.dumps([build.nvr for build in self.builds])

@property
def requirements_json(self):
return json.dumps(list(tokenize(self.requirements or '')))
@@ -35,7 +35,7 @@
// and hardcode something like this:
//var update = 'ugene-1.14.2-1.fc21';
var update = '${update.title}';
var since = '${update.last_modified.isoformat().rsplit(".", 1)[0]}';
var builds = ${update.builds_json | n};
// These are the required taskotron tests
var requirements = ${update.requirements_json | n};
@@ -198,12 +198,14 @@
gather_testcases(data.next);
// And queue up requests for the results of the testcases we already know about.
$.each(data.data, function(i, testcase) {
var param = $.param({
item: update,
since: since
$.each(builds, function(j, nvr) {
var param = $.param({
type: 'koji_build',
item: nvr,
});
var url = base_url + 'testcases/' + testcase.name + '/results?' + param;
request_resultsdb_page(url);
});
var url = base_url + 'testcases/' + testcase.name + '/results?' + param;
request_resultsdb_page(url);
});
}

0 comments on commit ce2394c

Please sign in to comment.
You can’t perform that action at this time.