Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Update.has_negative_karma() counts karma from before new or removed builds #1065
Bodhi's karma counting code resets the karma to 0 when builds are added or removed from an Update, and a user's karma from before the reset is not supposed to be counted:
This means that critical path updates that add or remove builds after receiving negative karma will still automatically get disabled when receiving new karma comments after the reset event because the old negative karma is still affecting the test. The old karma will not contribute to the Update's karma, however.
This is an edge case scenario, and fails in a "safe" way because the consequence is simply that autopush will get disabled for the Update. Therefore, I consider this a low priority issue.
I am adding a new