Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edited updates' builds get the pending_testing_tag instead of the pending_signing_tag #1067

Closed
bowlofeggs opened this issue Oct 27, 2016 · 0 comments · Fixed by #1068

Comments

@bowlofeggs
Copy link
Member

commented Oct 27, 2016

@puiterwijk found that we forgot to alter the code that edits existing updates such that it tags its builds with the pending_signing_tag instead of the pending_testing_tag as it does now.

This code:

            # Add the pending tag to all new builds
            for build in new_builds:
                if up.release.pending_testing_tag:
                    koji.tagBuild(up.release.pending_testing_tag, build)
                else:
                    # EL6 doesn't have these, and that's okay...
                    # We still warn in case the config gets messed up.
                    log.warn('%s has no pending_testing_tag' % up.release.name)

should be changed with s/pending_testing_tag/pending_signing_tag/g.

@bowlofeggs bowlofeggs self-assigned this Oct 27, 2016

bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue Oct 27, 2016
bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue Oct 27, 2016
bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue Oct 27, 2016
bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue Oct 27, 2016
bowlofeggs added a commit that referenced this issue Oct 27, 2016
amolkahat added a commit to amolkahat/bodhi that referenced this issue Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.