New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates with lots of Packages look unweildy #1351

Closed
ryanlerch opened this Issue Mar 16, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@ryanlerch
Contributor

ryanlerch commented Mar 16, 2017

The recent changes I made to bodhi on the updates page have not translated well for an update with a lot of builds attached to it. The title of the update includes all the packagenames of all the builds, resulting in:

bodhi-large-update

@ryanlerch

This comment has been minimized.

Show comment
Hide comment
@ryanlerch

ryanlerch Mar 16, 2017

Contributor

My proposal to fix this (and also #957) would be a two-pronged solution.

First, make the logic for this title a little saner. For an update with a single build, it behaves as normal:

enhancement update for inkscape in Fedora 25

For an update with 2 builds:

bugfix update for python-arrow & python-requests in Fedora 24

For an update with 3 or more builds:

security update for firefox, epiphany & 23 more in Fedora 25

The second prong would be to provide a new field tied to an update allowing a package maintainer to add a short description to a multi-build update. With it falling back to the above logic if one is not given. In the example given in the inital report, the short description could simply be "GNOME", so the label would read:

enhancement update for GNOME in Fedora 25
Contributor

ryanlerch commented Mar 16, 2017

My proposal to fix this (and also #957) would be a two-pronged solution.

First, make the logic for this title a little saner. For an update with a single build, it behaves as normal:

enhancement update for inkscape in Fedora 25

For an update with 2 builds:

bugfix update for python-arrow & python-requests in Fedora 24

For an update with 3 or more builds:

security update for firefox, epiphany & 23 more in Fedora 25

The second prong would be to provide a new field tied to an update allowing a package maintainer to add a short description to a multi-build update. With it falling back to the above logic if one is not given. In the example given in the inital report, the short description could simply be "GNOME", so the label would read:

enhancement update for GNOME in Fedora 25
@bowlofeggs

This comment has been minimized.

Show comment
Hide comment
@bowlofeggs

bowlofeggs Mar 17, 2017

Member

@ryanlerch I'm a +1 on your proposal. I suggest we do it in two separate issues/PRs since one is easier than the other.

Member

bowlofeggs commented Mar 17, 2017

@ryanlerch I'm a +1 on your proposal. I suggest we do it in two separate issues/PRs since one is easier than the other.

@ryanlerch

This comment has been minimized.

Show comment
Hide comment
@ryanlerch

ryanlerch Mar 19, 2017

Contributor

Okay!

I can do the first prong, but the second involves adding some database entries, so it's a little out of my skill range. Will get the PR done for the first one now.

Contributor

ryanlerch commented Mar 19, 2017

Okay!

I can do the first prong, but the second involves adding some database entries, so it's a little out of my skill range. Will get the PR done for the first one now.

@ryanlerch

This comment has been minimized.

Show comment
Hide comment
@ryanlerch

ryanlerch Mar 22, 2017

Contributor

Filed #1369 for the request of the new short description field for an update

Contributor

ryanlerch commented Mar 22, 2017

Filed #1369 for the request of the new short description field for an update

@bowlofeggs

This comment has been minimized.

Show comment
Hide comment
@bowlofeggs

bowlofeggs Mar 22, 2017

Member

This was fixed by #1370.

Member

bowlofeggs commented Mar 22, 2017

This was fixed by #1370.

@bowlofeggs bowlofeggs closed this Mar 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment