Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add knowledge of branch freezes to the Release model #1563

Closed
bowlofeggs opened this issue May 30, 2017 · 9 comments · Fixed by #3170

Comments

@bowlofeggs
Copy link
Member

@bowlofeggs bowlofeggs commented May 30, 2017

We should add the ability for Bodhi to know when a branched Release is frozen. During freeze periods, the masher should avoid mashing updates that are request stable, but it should allow exceptions by looking for blocker bugs. This way, releng doesn't have to run bodhi-push two times (once for the f-updates-testing, and again for all other stable releases).

@ryanlerch

This comment has been minimized.

Copy link
Contributor

@ryanlerch ryanlerch commented Jun 13, 2017

Related: #1038

@bowlofeggs

This comment has been minimized.

Copy link
Member Author

@bowlofeggs bowlofeggs commented Sep 17, 2018

UX-wise, we could give the CLI these commands to freeze and unfreeze F29 (for example):

$ bodhi releases freeze F29
$ bodhi releases unfreeze F29

Alternatively, we could just let the edit command flip a bool:

$ bodhi releases edit --name F29 --frozen true
$ bodhi releases edit --name F29 --frozen false
@bowlofeggs

This comment has been minimized.

Copy link
Member Author

@bowlofeggs bowlofeggs commented Mar 22, 2019

Since I wrote my comment suggesting a particular UX for this, Infrastructure has added some Ansible configs to track the status of releases. Thus, I think it would be most convenient for them if we did this in the configuration file for now, rather than via the CLI/API as I suggested above.

@mohanboddu @nirik, would you agree?

@mohanboddu

This comment has been minimized.

Copy link

@mohanboddu mohanboddu commented Apr 3, 2019

@bowlofeggs I still think its nice if bodhi knows what are the updates (testing only for a particular release and testing+stable for all other releases or testing+stable for all releases) that it needs to push depending on a release frozen status. So, your suggestion still helps, since the ansible config does all or nothing. So, if I say a release is frozen, then when bodhi-push is run it should push stable and testing updates for all other releases and testing only updates for frozen release.

@sebwoj

This comment has been minimized.

Copy link
Collaborator

@sebwoj sebwoj commented Apr 7, 2019

So the question is how Bodhi can fetch information about frozen release? Is there an api for that?

@bowlofeggs

This comment has been minimized.

Copy link
Member Author

@bowlofeggs bowlofeggs commented Apr 9, 2019

@sebwoj

This comment has been minimized.

Copy link
Collaborator

@sebwoj sebwoj commented Apr 14, 2019

Duplication #105

sebwoj added a commit to sebwoj/bodhi that referenced this issue Apr 20, 2019
fix fedora-infra#105
fix fedora-infra#1038
fix fedora-infra#1563

Signed-off-by: Sebastian Wojciechowski <s.wojciechowski89@gmail.com>
@sebwoj

This comment has been minimized.

Copy link
Collaborator

@sebwoj sebwoj commented May 1, 2019

Is it related to #794?

@bowlofeggs

This comment has been minimized.

Copy link
Member Author

@bowlofeggs bowlofeggs commented May 1, 2019

@sebwoj I think it's sort of related. The other ticket is about making it so Bodhi knows about a release before it manages it at all. This happens usually for about two weeks after Fedora branches a release from Rawhide. This ticket is about Bodhi not pushing out stable updates while continuing to push out testing updates during releng freezes (i.e., during the time that Bodhi does manage the release).

sebwoj added a commit to sebwoj/bodhi that referenced this issue May 2, 2019
fix fedora-infra#105
fix fedora-infra#1038
fix fedora-infra#1563

Signed-off-by: Sebastian Wojciechowski <s.wojciechowski89@gmail.com>
sebwoj added a commit to sebwoj/bodhi that referenced this issue May 2, 2019
fix fedora-infra#105
fix fedora-infra#1038
fix fedora-infra#1563

Signed-off-by: Sebastian Wojciechowski <s.wojciechowski89@gmail.com>
sebwoj added a commit to sebwoj/bodhi that referenced this issue Jun 11, 2019
fix fedora-infra#105
fix fedora-infra#1038
fix fedora-infra#1563

Signed-off-by: Sebastian Wojciechowski <s.wojciechowski89@gmail.com>
sebwoj added a commit to sebwoj/bodhi that referenced this issue Jun 11, 2019
fix fedora-infra#105
fix fedora-infra#1038
fix fedora-infra#1563

Signed-off-by: Sebastian Wojciechowski <s.wojciechowski89@gmail.com>
sebwoj added a commit to sebwoj/bodhi that referenced this issue Jun 20, 2019
fix fedora-infra#105
fix fedora-infra#1038
fix fedora-infra#1563

Signed-off-by: Sebastian Wojciechowski <s.wojciechowski89@gmail.com>
sebwoj added a commit to sebwoj/bodhi that referenced this issue Jun 21, 2019
fix fedora-infra#105
fix fedora-infra#1038
fix fedora-infra#1563

Signed-off-by: Sebastian Wojciechowski <s.wojciechowski89@gmail.com>
@mergify mergify bot closed this in #3170 Jun 21, 2019
mergify bot added a commit that referenced this issue Jun 21, 2019
fix #105
fix #1038
fix #1563

Signed-off-by: Sebastian Wojciechowski <s.wojciechowski89@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.