New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I was not offered the "push to batched" button when update reached days in testing #1875

Closed
bowlofeggs opened this Issue Oct 9, 2017 · 2 comments

Comments

Projects
None yet
1 participant
@bowlofeggs
Member

bowlofeggs commented Oct 9, 2017

When https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-1e6d4edc57 reached 14 days in testing, a "push to stable" button appeared, but no "push to batched". Perhaps we only remembered to add "push to batched" for karma-based pushes?

I was able to request it for batched using the CLI, so there is a workaround:

$ bodhi updates request FEDORA-EPEL-2017-1e6d4edc57 batched

@bowlofeggs bowlofeggs added EasyFix WebUI and removed EasyFix labels Oct 9, 2017

@bowlofeggs

This comment has been minimized.

Show comment
Hide comment
@bowlofeggs

bowlofeggs Oct 11, 2017

Member

I thought this would be an easy fix, but the template code that does this is a mess unfortunately.

Member

bowlofeggs commented Oct 11, 2017

I thought this would be an easy fix, but the template code that does this is a mess unfortunately.

@bowlofeggs bowlofeggs self-assigned this Oct 11, 2017

bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue Oct 11, 2017

Display the push to batched button for pushed updates.
The HTML template code is crazy[0,1] and its craziness was
underestimated when the batching feature was first written. It
turns out that it would only display the push to batched button for
unpushed updates.

This commit refactors the template code to be slightly less crazy
(further refactoring is certainly needed), and displays that button
on pushed updates. It also adds several test cases to assert that
the correct buttons appear at the right times.

These new tests revealed that the CI tests were leaking state, as
they would pass on their own but fail if the CI tests were run
first. Thus, this commit also refactors the CI tests to stop
leaking state by using mock.

fixes #1875
re #1887
re #1888

[0] fedora-infra#1887
[1] fedora-infra#1888

Signed-off-by: Randy Barlow <randy@electronsweatshop.com>

bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue Oct 11, 2017

Display the push to batched button for pushed updates.
The HTML template code is crazy[0,1] and its craziness was
underestimated when the batching feature was first written. It
turns out that it would only display the push to batched button for
unpushed updates.

This commit refactors the template code to be slightly less crazy
(further refactoring is certainly needed), and displays that button
on pushed updates. It also adds several test cases to assert that
the correct buttons appear at the right times.

These new tests revealed that the CI tests were leaking state, as
they would pass on their own but fail if the CI tests were run
first. Thus, this commit also refactors the CI tests to stop
leaking state by using mock.

fixes #1875
re #1887
re #1888

[0] fedora-infra#1887
[1] fedora-infra#1888

Signed-off-by: Randy Barlow <randy@electronsweatshop.com>

bowlofeggs added a commit that referenced this issue Oct 11, 2017

Display the push to batched button for pushed updates.
The HTML template code is crazy[0,1] and its craziness was
underestimated when the batching feature was first written. It
turns out that it would only display the push to batched button for
unpushed updates.

This commit refactors the template code to be slightly less crazy
(further refactoring is certainly needed), and displays that button
on pushed updates. It also adds several test cases to assert that
the correct buttons appear at the right times.

These new tests revealed that the CI tests were leaking state, as
they would pass on their own but fail if the CI tests were run
first. Thus, this commit also refactors the CI tests to stop
leaking state by using mock.

fixes #1875
re #1887
re #1888

[0] #1887
[1] #1888

Signed-off-by: Randy Barlow <randy@electronsweatshop.com>
@bowlofeggs

This comment has been minimized.

Show comment
Hide comment
@bowlofeggs

bowlofeggs Oct 12, 2017

Member

This is fixed in the 2.12.2 release.

Member

bowlofeggs commented Oct 12, 2017

This is fixed in the 2.12.2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment