Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client crash when submitting multiple BuildrootOverrides in one call #2031

Closed
bowlofeggs opened this issue Nov 17, 2017 · 3 comments
Closed
Labels
Buildroot Override Issues related to buildroot overrides Client Issues with the bodhi command line interface tool Crash Issues related to an unhandled crash

Comments

@bowlofeggs
Copy link
Contributor

Mamoru TASAKA reported to Red Hat Bugzilla that the Bodhi client crashes when a list of BuildrootOverrides are created in one call.

Description of problem:
Submitting override with multiple packages at once causes bodhi crash
(although the override seems to be registered anyway)

Version-Release number of selected component (if applicable):
bodhi-client-2.12.2-2.fc27

How reproducible:
100%

Steps to Reproduce:

  1. See below

Actual results:
[mtasaka@localhost fedora-specific]$ bodhi overrides save --user mtasaka --duration 4 --notes "ruby-gnome2 3.2.0 suite stage 2" "rubygem-gobject-introspection-3.2.0-1.fc27 rubygem-cairo-gobject-3.2.0-1.fc27"
mtasaka's rubygem-gobject-introspection-3.2.0-1.fc27 override (expires 2017-11-20 04:53:57)
mtasaka's rubygem-cairo-gobject-3.2.0-1.fc27 override (expires 2017-11-20 04:53:57)
Traceback (most recent call last):
File "/bin/bodhi", line 11, in
load_entry_point('bodhi-client==2.12.2', 'console_scripts', 'bodhi')()
File "/usr/lib/python2.7/site-packages/click/core.py", line 722, in call
return self.main(*args, **kwargs)
File "/usr/lib/python2.7/site-packages/click/core.py", line 697, in main
rv = self.invoke(ctx)
File "/usr/lib/python2.7/site-packages/click/core.py", line 1066, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/lib/python2.7/site-packages/click/core.py", line 1066, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/lib/python2.7/site-packages/click/core.py", line 895, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/lib/python2.7/site-packages/click/core.py", line 535, in invoke
return callback(*args, **kwargs)
File "/usr/lib/python2.7/site-packages/bodhi/client/init.py", line 111, in wrapper
method(*args, **kwargs)
File "/usr/lib/python2.7/site-packages/bodhi/client/init.py", line 600, in save_buildroot_overrides
_save_override(url=url, user=user, password=password, staging=staging, **kwargs)
File "/usr/lib/python2.7/site-packages/bodhi/client/init.py", line 141, in _save_override
print_resp(resp, client)
File "/usr/lib/python2.7/site-packages/bodhi/client/init.py", line 658, in print_resp
'%s overrides found (%d shown)' % (resp.total, len(resp.overrides)))
File "/usr/lib/python2.7/site-packages/munch/init.py", line 103, in getattr
raise AttributeError(k)
AttributeError: total

@bowlofeggs bowlofeggs added Buildroot Override Issues related to buildroot overrides Client Issues with the bodhi command line interface tool Crash Issues related to an unhandled crash labels Nov 17, 2017
sebwoj added a commit to sebwoj/bodhi that referenced this issue Jan 2, 2019
Fixed fedora-infra#2031

Signed-off-by: Sebastian Wojciechowski <s.wojciechowski89@gmail.com>
bowlofeggs pushed a commit to sebwoj/bodhi that referenced this issue Jan 8, 2019
Fixed fedora-infra#2031

Signed-off-by: Sebastian Wojciechowski <s.wojciechowski89@gmail.com>
@bowlofeggs
Copy link
Contributor Author

This fix is planned for inclusion in Bodhi 3.13: #2917.

mergify bot pushed a commit that referenced this issue Jan 10, 2019
Fixed #2031

Signed-off-by: Sebastian Wojciechowski <s.wojciechowski89@gmail.com>
(cherry picked from commit a9b52c2)
mergify bot pushed a commit that referenced this issue Jan 11, 2019
Fixed #2031

Signed-off-by: Sebastian Wojciechowski <s.wojciechowski89@gmail.com>
(cherry picked from commit a9b52c2)
@bowlofeggs
Copy link
Contributor Author

@bowlofeggs
Copy link
Contributor Author

Bodhi 3.13.0 has been released:

https://github.com/fedora-infra/bodhi/releases/tag/3.13.0

Fedora Infrastructure plans to deploy it to production on Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Buildroot Override Issues related to buildroot overrides Client Issues with the bodhi command line interface tool Crash Issues related to an unhandled crash
Projects
None yet
Development

No branches or pull requests

1 participant