Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bodhi's update create form does not gracefully handle errors from the backend #3035

Closed
bowlofeggs opened this Issue Feb 20, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@bowlofeggs
Copy link
Member

bowlofeggs commented Feb 20, 2019

When users were hitting #3024, the web form's submit button would spin until it hit the error and then it would stop spinning, but no error was reported to the user. This made it non-obvious that there was a problem, and also made it more difficult to determine what the real problem was.

The web form (and all of Bodhi's forms) should be able to display errors from the backend to the user on non-2xx codes.

@sebwoj

This comment has been minimized.

Copy link
Collaborator

sebwoj commented Feb 21, 2019

It looks like duplication of #2312

sebwoj added a commit to sebwoj/bodhi that referenced this issue Feb 26, 2019

Add json response handler for server internal errors
Fixes fedora-infra#3035

Signed-off-by: Sebastian Wojciechowski <s.wojciechowski89@gmail.com>
@bowlofeggs

This comment has been minimized.

Copy link
Member Author

bowlofeggs commented Mar 7, 2019

@sebwoj ah yeah, I guess it is ultimately the same thing. The other one is a bit more specific though I guess. Thanks!

bowlofeggs added a commit to sebwoj/bodhi that referenced this issue Mar 13, 2019

Add json response handler for server internal errors
Fixes fedora-infra#3035

Signed-off-by: Sebastian Wojciechowski <s.wojciechowski89@gmail.com>

mergify bot added a commit that referenced this issue Mar 13, 2019

Add json response handler for server internal errors
Fixes #3035

Signed-off-by: Sebastian Wojciechowski <s.wojciechowski89@gmail.com>

@bowlofeggs bowlofeggs closed this Mar 13, 2019

@bowlofeggs bowlofeggs referenced this issue Mar 22, 2019

Closed

Release Bodhi 3.14.0 #3084

0 of 3 tasks complete

mergify bot pushed a commit that referenced this issue Mar 26, 2019

Add json response handler for server internal errors
Fixes #3035

Signed-off-by: Sebastian Wojciechowski <s.wojciechowski89@gmail.com>
(cherry picked from commit 2d30986)

# Conflicts:
#	bodhi/server/views/generic.py

abompard added a commit that referenced this issue Mar 26, 2019

Add json response handler for server internal errors
Fixes #3035

Signed-off-by: Sebastian Wojciechowski <s.wojciechowski89@gmail.com>
(cherry picked from commit 2d30986)

abompard added a commit that referenced this issue Mar 26, 2019

Add json response handler for server internal errors
Fixes #3035

Signed-off-by: Sebastian Wojciechowski <s.wojciechowski89@gmail.com>
(cherry picked from commit 2d30986)

abompard added a commit that referenced this issue Mar 26, 2019

Add json response handler for server internal errors
Fixes #3035

Signed-off-by: Sebastian Wojciechowski <s.wojciechowski89@gmail.com>
(cherry picked from commit 2d30986)

abompard added a commit that referenced this issue Mar 27, 2019

Add json response handler for server internal errors
Fixes #3035

Signed-off-by: Sebastian Wojciechowski <s.wojciechowski89@gmail.com>
(cherry picked from commit 2d30986)

abompard added a commit that referenced this issue Mar 27, 2019

Add json response handler for server internal errors
Fixes #3035

Signed-off-by: Sebastian Wojciechowski <s.wojciechowski89@gmail.com>
(cherry picked from commit 2d30986)

abompard added a commit that referenced this issue Mar 27, 2019

Add json response handler for server internal errors
Fixes #3035

Signed-off-by: Sebastian Wojciechowski <s.wojciechowski89@gmail.com>
(cherry picked from commit 2d30986)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.