Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic updates should be filled with information from the RPM changelog #3192

Closed
nphilipp opened this issue Apr 29, 2019 · 3 comments · Fixed by #3548
Assignees
Labels
Projects

Comments

@nphilipp
Copy link
Member

@nphilipp nphilipp commented Apr 29, 2019

This is a continuation of issue #3007 and covers items deemed not that high of a priority, not needed for the MVP.

As a Bodhi user, when an update is created automatically because a build was tagged into a certain tag, I want that new entries in the changelog are evaluated and:

  • discovered Bugzilla tickets are associated with the update
  • changelog entries are used to pre-fill the update notes

so that the update is more informational.

Thoughts:

  • We need to figure out what the new changelog entries are. Between builds, we could e.g. have more than one entry. Old entries could even be removed, or existing metadata changed (e.g. when a previously wrong changelog date or weekday is fixed) which makes discovery of "what is new" harder.
  • When a new build triggers a new update, it should probably obsolete and already existing (but active) update of the same package, and inherit Bugzilla tickets and update notes. With manually created updates, the notes could just be merged and the maintainer would sort out commonalities etc. How would we handle this automatically?
@keszybz

This comment has been minimized.

Copy link

@keszybz keszybz commented May 6, 2019

This applies to "manual" updates too. It'd be great if bodhi could pre-fill the bug description with bug numbers and the text from the changelog. Right now bodhi suggests no text and for bugs it just picks a few bugs from the list of open bugs, which means that for packages with many bugs open the suggestion is essentially useless. The text would often have to be edited (because the level of detail in the changelog is different), but it'd be a good start and make things quicker in many cases.

@cverna cverna moved this from To do to Ready in CI Gating May 9, 2019
@cverna cverna moved this from Ready to To do in CI Gating May 9, 2019
@ryanlerch ryanlerch self-assigned this Aug 13, 2019
@ryanlerch ryanlerch moved this from To do to Ready in CI Gating Aug 13, 2019
@bowlofeggs

This comment has been minimized.

Copy link
Member

@bowlofeggs bowlofeggs commented Aug 26, 2019

@ryanlerch Are you still planning to work on this? If not, I might take a swing at it.

I think we can break this code out into its own function to get the changelog for us here (and to continue to do so for the e-mails):

bodhi/bodhi/server/mail.py

Lines 342 to 354 in 41412ff

# Grab the RPM header of the previous update, and generate a ChangeLog
info['changelog'] = ""
if lastpkg:
oldh = get_rpm_header(lastpkg)
oldtime = oldh['changelogtime']
text = oldh['changelogtext']
del oldh
if not text:
oldtime = 0
elif isinstance(oldtime, list):
oldtime = oldtime[0]
info['changelog'] = "ChangeLog:\n\n%s%s" % \
(build.get_changelog(oldtime), line)

@ryanlerch ryanlerch removed their assignment Sep 26, 2019
@ryanlerch ryanlerch self-assigned this Oct 10, 2019
@ryanlerch ryanlerch moved this from Ready to In progress in CI Gating Oct 10, 2019
ryanlerch added a commit to ryanlerch/bodhi that referenced this issue Oct 10, 2019
Related:fedora-infra#3192

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
ryanlerch added a commit to ryanlerch/bodhi that referenced this issue Oct 10, 2019
Fixes: fedora-infra#3192

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
@ryanlerch ryanlerch moved this from In progress to Need Review in CI Gating Oct 10, 2019
ryanlerch added a commit to ryanlerch/bodhi that referenced this issue Oct 14, 2019
Related:fedora-infra#3192

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
ryanlerch added a commit to ryanlerch/bodhi that referenced this issue Oct 14, 2019
Fixes: fedora-infra#3192

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
ryanlerch added a commit to ryanlerch/bodhi that referenced this issue Oct 14, 2019
Fixes: fedora-infra#3192

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
ryanlerch added a commit to ryanlerch/bodhi that referenced this issue Oct 14, 2019
move changelog generation from mail.py to util.py
then, Add changelog to update notes for automatic updates

Fixes: fedora-infra#3192

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
ryanlerch added a commit to ryanlerch/bodhi that referenced this issue Oct 15, 2019
move changelog generation from mail.py to util.py
then, Add changelog to update notes for automatic updates

Fixes: fedora-infra#3192

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
nphilipp added a commit to ryanlerch/bodhi that referenced this issue Oct 15, 2019
move changelog generation from mail.py to util.py
then, Add changelog to update notes for automatic updates

Fixes: fedora-infra#3192

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
ryanlerch added a commit to ryanlerch/bodhi that referenced this issue Oct 18, 2019
move changelog generation from mail.py to util.py
then, Add changelog to update notes for automatic updates

Fixes: fedora-infra#3192

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
@mergify mergify bot closed this in #3548 Oct 18, 2019
CI Gating automation moved this from Need Review to Merged to develop Oct 18, 2019
mergify bot added a commit that referenced this issue Oct 18, 2019
move changelog generation from mail.py to util.py
then, Add changelog to update notes for automatic updates

Fixes: #3192

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
@keszybz

This comment has been minimized.

Copy link

@keszybz keszybz commented Oct 18, 2019

Wow, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
CI Gating
  
Merged to develop
4 participants
You can’t perform that action at this time.