Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ctype to the ComposeComplete schema #3297

Closed
owtaylor opened this issue Jun 6, 2019 · 0 comments · Fixed by #3329
Assignees

Comments

@owtaylor
Copy link
Contributor

@owtaylor owtaylor commented Jun 6, 2019

Currently the regindexer code that maintains an index of Flatpaks and containers in the Fedora registry looks at the 'ctype' field of a mashtaskcompose.complete message to know whether the index needs to be rebuilt:

   match_topic = conf.daemon.topic_prefix + '.' + conf.daemon.environment + '.bodhi.masktask.complete'
   for name, endpoint, topic, raw_msg in fedmsg.tail_messages(topic=match_topic):
        msg = raw_msg['msg']
        if msg.get('ctype') in ('container', 'flatpak'):
            indexer_thread.reindex('Bodhi mash, ctype="%s"' % msg['ctype'])

The ctype field is not part of the ComposeCompleteV1 schema - it would be great if it could be added, since I'd like to continue using it when switching to fedora-messaging.

(@bowlofeggs suggested possibly extending the topic - I suppose like compose.complete.flatpak - I don't see a reason to go that fancy - there are few compose.complete messages.)

@Zlopez Zlopez self-assigned this Jun 19, 2019
Zlopez added a commit to Zlopez/bodhi that referenced this issue Jun 19, 2019
Fixes fedora-infra#3297

Signed-off-by: Michal Konečný <mkonecny@redhat.com>
Zlopez added a commit to Zlopez/bodhi that referenced this issue Jun 19, 2019
Fixes fedora-infra#3297

Signed-off-by: Michal Konečný <mkonecny@redhat.com>
Zlopez added a commit to Zlopez/bodhi that referenced this issue Jun 20, 2019
Fixes fedora-infra#3297

Signed-off-by: Michal Konečný <mkonecny@redhat.com>
@mergify mergify bot closed this in #3329 Jun 21, 2019
mergify bot added a commit that referenced this issue Jun 21, 2019
Fixes #3297

Signed-off-by: Michal Konečný <mkonecny@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.