Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic rawhide updates should not list karma limits #3424

Closed
hroncok opened this issue Jul 25, 2019 · 7 comments · Fixed by #3517
Assignees
Labels
Projects

Comments

@hroncok
Copy link
Contributor

@hroncok hroncok commented Jul 25, 2019

I think that the highlighted part of an update overview page should not be visible in an automated rawhide update:

_

@cverna

This comment has been minimized.

Copy link
Member

@cverna cverna commented Jul 25, 2019

@hroncok karma is actually valid on updates created by rawhide. So if an update gets a -1 karma it would block the update from being pushed to stable.

Apart from being automatically created the updates in rawhide are exactly the same as the one in a stable release.

@hroncok

This comment has been minimized.

Copy link
Contributor Author

@hroncok hroncok commented Jul 25, 2019

So before the tests finish, users have a chance to quickly do -3 karma? Is that really possible?

@hroncok

This comment has been minimized.

Copy link
Contributor Author

@hroncok hroncok commented Jul 25, 2019

Oh, sorry, they can do a quick -1 to block it and than extra -2 unpushes it?

@hroncok

This comment has been minimized.

Copy link
Contributor Author

@hroncok hroncok commented Jul 25, 2019

Does +3 override the test failure?

@cverna

This comment has been minimized.

Copy link
Member

@cverna cverna commented Jul 25, 2019

Does +3 override the test failure?

If gating is enabled on the release then no, the update would still be blocked by the failing tests.

@hroncok

This comment has been minimized.

Copy link
Contributor Author

@hroncok hroncok commented Jul 25, 2019

It just feels that the autokarma thing is not relevant then. What am I missing?

@cverna

This comment has been minimized.

Copy link
Member

@cverna cverna commented Jul 25, 2019

It just feels that the autokarma thing is not relevant then. What am I missing?

Yes I don't think anyone will use karma on any rawhide update. What could be easily done is to disable autokarma on the rawhide update but you would still see the karma bits in the update view. Just the Autopush (karma) bit would be showing disabled instead of `enabled.

@ryanlerch ryanlerch added this to To do in CI Gating via automation Aug 16, 2019
@ryanlerch ryanlerch added the WebUI label Aug 16, 2019
@ryanlerch ryanlerch self-assigned this Aug 16, 2019
ryanlerch added a commit to ryanlerch/bodhi that referenced this issue Sep 25, 2019
having autokarma and autotime does not really make
much sense for automatic updates, so this turns it off.

Additionally, the recently merged UI refresh hides some
items if they are turned off, making the ui cleaner for
the user.

Fixes: fedora-infra#3424

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
@ryanlerch ryanlerch moved this from To do to Need Review in CI Gating Sep 25, 2019
ryanlerch added a commit to ryanlerch/bodhi that referenced this issue Sep 25, 2019
having autokarma and autotime does not really make
much sense for automatic updates, so this turns it off.

Additionally, the recently merged UI refresh hides some
items if they are turned off, making the ui cleaner for
the user.

Fixes: fedora-infra#3424

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
@mergify mergify bot closed this in #3517 Sep 25, 2019
CI Gating automation moved this from Need Review to Merged to develop Sep 25, 2019
mergify bot added a commit that referenced this issue Sep 25, 2019
having autokarma and autotime does not really make
much sense for automatic updates, so this turns it off.

Additionally, the recently merged UI refresh hides some
items if they are turned off, making the ui cleaner for
the user.

Fixes: #3424

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
CI Gating
  
Merged to develop
3 participants
You can’t perform that action at this time.