Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow buildroot override in rawhide #3447

Closed
pypingou opened this issue Aug 1, 2019 · 2 comments · Fixed by #3474
Assignees
Projects

Comments

@pypingou
Copy link
Member

@pypingou pypingou commented Aug 1, 2019

If the user creates a buildroot override in rawhide it ends up messing with our entire workflow. The builds are no longer in their appropriate tags, they appear in bodhi's database but aren't linked to any update (cf PR: #3446) that leads to basically builds being stuck.

Preventing buildroot override creation in rawhide should just solve that :)

@pypingou pypingou created this issue from a note in CI Gating (Ready) Aug 1, 2019
@cverna

This comment has been minimized.

Copy link
Member

@cverna cverna commented Aug 2, 2019

One possible easy way to do this is to not configure the override tag for the rawhide release.

@pypingou

This comment has been minimized.

Copy link
Member Author

@pypingou pypingou commented Aug 2, 2019

Wfm, we just need to document this enough to make sure we don't miss it at branching

@cverna cverna self-assigned this Aug 19, 2019
@cverna cverna moved this from Ready to In progress in CI Gating Aug 19, 2019
cverna added a commit to cverna/bodhi that referenced this issue Aug 19, 2019
A few releases do not make use of the buildroot override
(eg container, rawhide, flatpak). This commit makes it possible
to create a release without the override tag.
If an user tries to create a buildroot override for such a release
an error message will be displayed.

Fixes fedora-infra#3447

Signed-off-by: Clement Verna <cverna@tutanota.com>
@cverna cverna moved this from In progress to Need Review in CI Gating Aug 19, 2019
cverna added a commit to cverna/bodhi that referenced this issue Aug 19, 2019
A few releases do not make use of the buildroot override
(eg container, rawhide, flatpak). This commit makes it possible
to create a release without the override tag.
If an user tries to create a buildroot override for such a release
an error message will be displayed.

Fixes fedora-infra#3447

Signed-off-by: Clement Verna <cverna@tutanota.com>
cverna added a commit to cverna/bodhi that referenced this issue Aug 19, 2019
A few releases do not make use of the buildroot override
(eg container, rawhide, flatpak). This commit makes it possible
to create a release without the override tag.
If an user tries to create a buildroot override for such a release
an error message will be displayed.

Fixes fedora-infra#3447

Signed-off-by: Clement Verna <cverna@tutanota.com>
cverna added a commit to cverna/bodhi that referenced this issue Aug 19, 2019
A few releases do not make use of the buildroot override
(eg container, rawhide, flatpak). This commit makes it possible
to create a release without the override tag.
If an user tries to create a buildroot override for such a release
an error message will be displayed.

Fixes fedora-infra#3447

Signed-off-by: Clement Verna <cverna@tutanota.com>
cverna added a commit to cverna/bodhi that referenced this issue Aug 20, 2019
A few releases do not make use of the buildroot override
(eg container, rawhide, flatpak). This commit makes it possible
to create a release without the override tag.
If an user tries to create a buildroot override for such a release
an error message will be displayed.

Fixes fedora-infra#3447

Signed-off-by: Clement Verna <cverna@tutanota.com>
@mergify mergify bot closed this in #3474 Aug 21, 2019
CI Gating automation moved this from Need Review to Merged to develop Aug 21, 2019
mergify bot added a commit that referenced this issue Aug 21, 2019
A few releases do not make use of the buildroot override
(eg container, rawhide, flatpak). This commit makes it possible
to create a release without the override tag.
If an user tries to create a buildroot override for such a release
an error message will be displayed.

Fixes #3447

Signed-off-by: Clement Verna <cverna@tutanota.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
CI Gating
  
Merged to develop
2 participants
You can’t perform that action at this time.