Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bodhi client requires display_name field during update #3470

Closed
onosek opened this issue Aug 15, 2019 · 4 comments
Assignees
Labels

Comments

@onosek
Copy link
Contributor

@onosek onosek commented Aug 15, 2019

Hi,

I am maintaining fedpkg. Recently it started failing because of new bodhi client bug/feature that allows the user to customize the name of the update (display_name). It happened in bodhi-4.1.0-3 which build is available (only) for Fedora31. I temporarily fixed it for Fedora31, but as this bodhi change is not backwards compatible, it is complicated to resolve it for other releases. I would have to test which bodhi version is available and upon this test result, I would need to customize communication with bodhi client. And for every release require a different version of bodhi.
Bodhi web interface AFAIK doesn't require any input in this field. Why bodhi client interface requires it? Isn't it possible to change this behaviour from mandatory to optional?
Thank you.

You can see more information here:

@ryanlerch ryanlerch added the Client label Aug 16, 2019
@ryanlerch

This comment has been minimized.

Copy link
Contributor

@ryanlerch ryanlerch commented Aug 16, 2019

It looks like that the issue here is that fedpkg is not supplying the display_name item in the update config file it is passing to the bodhi CLI.

the Bugs field is not mandatory either, but the config file that fedpkg supplies to bodhi (if there are no bugs), contains the field, but is empty. Pretty sure that changing the config template in fedpkg to contain the field, but defining it as empty will fix this issue.

@lubomir

This comment has been minimized.

Copy link
Contributor

@lubomir lubomir commented Aug 16, 2019

It does fix the issue if you have bodhi client 4.1.0. If display_name is included in the template for 4.0.2, bodhi will complain and crash. Basically fedpkg would have to do runtime detection of minor bodhi version. It seems much easier to provide default empty value in bodhi directly. Otherwise I think a major version bump is in order, since it breaks backwards compatibility.

@ryanlerch ryanlerch self-assigned this Aug 19, 2019
@onosek

This comment has been minimized.

Copy link
Contributor Author

@onosek onosek commented Aug 27, 2019

Hi @ryanlerch, I would like to ask about the situation. Is there any plan for fixing this? If yes, what is your time estimation? Thank you.

onosek added a commit to onosek/bodhi that referenced this issue Sep 9, 2019
Bodhi version 4.1.0-3 makes this parameter mandatory and it breaks
backward compatibility for fedpkg, which uses older versions of bodhi.

Issue: fedora-infra#3470
Fixes: rhbz#1737426

Signed-off-by: Ondrej Nosek <onosek@redhat.com>
onosek added a commit to onosek/bodhi that referenced this issue Sep 9, 2019
Bodhi version 4.1.0-3 makes this parameter mandatory and it breaks
backward compatibility for fedpkg, which uses older versions of bodhi.

Issue: fedora-infra#3470
Fixes: rhbz#1737426

Signed-off-by: Ondrej Nosek <onosek@redhat.com>
onosek added a commit to onosek/bodhi that referenced this issue Sep 9, 2019
Bodhi version 4.1.0-3 makes this parameter mandatory and it breaks
backward compatibility for fedpkg, which uses older versions of bodhi.

Issue: fedora-infra#3470
Fixes: rhbz#1737426

Signed-off-by: Ondrej Nosek <onosek@redhat.com>
mergify bot added a commit that referenced this issue Sep 25, 2019
Bodhi version 4.1.0-3 makes this parameter mandatory and it breaks
backward compatibility for fedpkg, which uses older versions of bodhi.

Issue: #3470
Fixes: rhbz#1737426

Signed-off-by: Ondrej Nosek <onosek@redhat.com>
@onosek

This comment has been minimized.

Copy link
Contributor Author

@onosek onosek commented Sep 27, 2019

Closing this issue as a requested change was merged. Going to be released soon in bodhi 5.

@onosek onosek closed this Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.