Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update without build can be created #3471

Closed
cverna opened this issue Aug 16, 2019 · 4 comments · Fixed by #3581
Labels

Comments

@cverna
Copy link
Member

@cverna cverna commented Aug 16, 2019

It appears that an update without build can be created (https://bodhi.fedoraproject.org/updates/FEDORA-2019-e4e61bb84b).
We need to make sure that the validators are not letting an update without a build being created.

In that case the update made the compose failed.

@cverna cverna added the Crash label Aug 16, 2019
@cverna

This comment has been minimized.

Copy link
Member Author

@cverna cverna commented Sep 1, 2019

This seems to happen if you create an update with build A, then create the another update with the same build.

@ryanlerch

This comment has been minimized.

Copy link
Contributor

@ryanlerch ryanlerch commented Sep 12, 2019

Related: #3495

@cverna

This comment has been minimized.

Copy link
Member Author

@cverna cverna commented Sep 30, 2019

This happened again today, some more info from the IRC log

15:37 <RemiFedora> cverna, bodhi hangs during the "submit" (btw, it have properly obsolete an old update)
15:37 <RemiFedora> so I press "submit" another time, and get the proper update, with the build (but without the changelog from the obsoleted one...)

It seems to happen when bodhi hangs, I guess that we could check if an update has a build before commiting to the db.

Zlopez added a commit to Zlopez/bodhi that referenced this issue Oct 17, 2019
Fixes fedora-infra#3471

Signed-off-by: Michal Konečný <mkonecny@redhat.com>
@mohanboddu

This comment has been minimized.

Copy link

@mohanboddu mohanboddu commented Oct 17, 2019

I was supposed to comment here, but couldn't find the ticket:

#3495 (comment)

Zlopez added a commit to Zlopez/bodhi that referenced this issue Oct 21, 2019
Fixes fedora-infra#3471

Signed-off-by: Michal Konečný <mkonecny@redhat.com>
@mergify mergify bot closed this in #3581 Oct 24, 2019
mergify bot added a commit that referenced this issue Oct 24, 2019
Fixes #3471

Signed-off-by: Michal Konečný <mkonecny@redhat.com>
mergify bot pushed a commit that referenced this issue Oct 24, 2019
Fixes #3471

Signed-off-by: Michal Konečný <mkonecny@redhat.com>
(cherry picked from commit ab19943)
mergify bot added a commit that referenced this issue Oct 24, 2019
Fixes #3471

Signed-off-by: Michal Konečný <mkonecny@redhat.com>
(cherry picked from commit ab19943)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.