Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move successfully tested update from testing to stable and remove side and aux tags. #3476

Closed
nphilipp opened this issue Aug 19, 2019 · 2 comments
Assignees
Projects

Comments

@nphilipp
Copy link
Member

@nphilipp nphilipp commented Aug 19, 2019

Story

As a user of multi-build gating,

when the tests of an update created for a side tag are finished successfully (i.e. an according gating decision has been announced on the message bus), I want Bodhi to:

  • add a comment documenting the decision to the update
  • tag its builds into the stable tag and out of the *-testing tag of the side tag
  • change the status of an update created for a side-tag to stable
  • and remove the side tag and its auxiliary tags

so that the update and the build artifacts contained in it are made available for the general public.

Background

pypingou's multi-build update workflow diagram [download]:

Multi-builds - Rawhide Package Gating Flow.png

This card corresponds to the bottom-most bubble in the Bodhi column.

NB: This diagram is about the Rawhide workflow. Other inputs are going into this last step, like pushing the update because it spent enough time in testing (Update.autotime, which happens to default to 0 in Rawhide), or because it has gathered enough karma (Update.autokarma).

@nphilipp nphilipp created this issue from a note in CI Gating (To do) Aug 19, 2019
@nphilipp nphilipp changed the title Message consumer: Move tested update from testing to stable and remove side and aux tags. Move successfully tested update from testing to stable and remove side and aux tags. Aug 20, 2019
@nphilipp nphilipp moved this from To do to In progress in CI Gating Aug 27, 2019
@nphilipp

This comment has been minimized.

Copy link
Member Author

@nphilipp nphilipp commented Aug 27, 2019

Not sure how far I'll get with this before going on vacation but I'll give it a shot.

@nphilipp

This comment has been minimized.

Copy link
Member Author

@nphilipp nphilipp commented Aug 28, 2019

After my first implementation attempt and some discussion, it seems that the first three items work already, in the greenwave consumer and the approve_testing script. I've implemented the last item in the script, too: PR #3489 which is WIP right now because there are no tests yet.

@nphilipp nphilipp moved this from In progress to Need Review in CI Gating Aug 28, 2019
nphilipp added a commit to nphilipp/bodhi that referenced this issue Aug 28, 2019
Fixes: fedora-infra#3476

Signed-off-by: Nils Philippsen <nils@redhat.com>
@Zlopez Zlopez self-assigned this Aug 29, 2019
Zlopez added a commit to nphilipp/bodhi that referenced this issue Sep 5, 2019
Fixes: fedora-infra#3476

Signed-off-by: Nils Philippsen <nils@redhat.com>
cverna added a commit to nphilipp/bodhi that referenced this issue Sep 5, 2019
Fixes: fedora-infra#3476

Signed-off-by: Nils Philippsen <nils@redhat.com>
cverna added a commit to nphilipp/bodhi that referenced this issue Sep 9, 2019
This commits makes sure that the additional tags and the original
side tag are deleted once the update was pushed to stable.

Signed-off-by: Nils Philippsen <nils@redhat.com>

Log identical timestamps for the same operation

Signed-off-by: Nils Philippsen <nils@redhat.com>

Remove side and aux tags when closing out updates

Fixes: fedora-infra#3476

Signed-off-by: Nils Philippsen <nils@redhat.com>

Refactor the approve testing script for multi build updates.

This commit makes the approve testing script easier to follow
by splitting the logic for single build updates, multi build updates
and updates composed by bodhi.
Notes: For updates that are not composed by bodhi we do not
use the set_requests method anymore. This is really only useful
for the composer and makes things simplier in the rawhide context.

Signed-off-by: Clement Verna <cverna@tutanota.com>
@mergify mergify bot closed this in e36fc94 Sep 9, 2019
CI Gating automation moved this from Need Review to Merged to develop Sep 9, 2019
ryanlerch added a commit to ryanlerch/bodhi that referenced this issue Sep 18, 2019
This commits makes sure that the additional tags and the original
side tag are deleted once the update was pushed to stable.

Signed-off-by: Nils Philippsen <nils@redhat.com>

Log identical timestamps for the same operation

Signed-off-by: Nils Philippsen <nils@redhat.com>

Remove side and aux tags when closing out updates

Fixes: fedora-infra#3476

Signed-off-by: Nils Philippsen <nils@redhat.com>

Refactor the approve testing script for multi build updates.

This commit makes the approve testing script easier to follow
by splitting the logic for single build updates, multi build updates
and updates composed by bodhi.
Notes: For updates that are not composed by bodhi we do not
use the set_requests method anymore. This is really only useful
for the composer and makes things simplier in the rawhide context.

Signed-off-by: Clement Verna <cverna@tutanota.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
CI Gating
  
Merged to develop
2 participants
You can’t perform that action at this time.