Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to edit a side-tag update #3485

Closed
ryanlerch opened this issue Aug 26, 2019 · 0 comments · Fixed by #3520
Labels
Projects

Comments

@ryanlerch
Copy link
Contributor

@ryanlerch ryanlerch commented Aug 26, 2019

When trying to edit/update the builds of a side-tag update (by keeping the from_tag field, and giving an empty builds field), bodhi returns the following error to the user:

Builds: Failed to create update. tag requires autosign permission

the following traceback is returned on the server.

2019-08-26 06:53:52,584 ERROR [bodhi.server][waitress] Failed to create update
Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/koji/__init__.py", line 2527, in _callMethod
    return self._sendCall(handler, headers, request)
  File "/usr/lib/python3.7/site-packages/koji/__init__.py", line 2449, in _sendCall
    return self._sendOneCall(handler, headers, request)
  File "/usr/lib/python3.7/site-packages/koji/__init__.py", line 2491, in _sendOneCall
    ret = self._read_xmlrpc_response(r)
  File "/usr/lib/python3.7/site-packages/koji/__init__.py", line 2503, in _read_xmlrpc_response
    result = u.close()
  File "/usr/lib64/python3.7/xmlrpc/client.py", line 656, in close
    raise Fault(**self._stack[0])
xmlrpc.client.Fault: <Fault 1004: 'tag requires autosign permission'>
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/home/vagrant/bodhi/bodhi/server/services/updates.py", line 514, in new_update
    result, _caveats = Update.edit(request, data)
  File "/home/vagrant/bodhi/bodhi/server/models.py", line 2314, in edit
    koji.tagBuild(up.release.pending_signing_tag, build)
  File "/usr/lib/python3.7/site-packages/koji/__init__.py", line 2055, in __call__
    return self.__func(self.__name, args, opts)
  File "/usr/lib/python3.7/site-packages/koji/__init__.py", line 2546, in _callMethod
    raise err
koji.ActionNotAllowed: tag requires autosign permission
@cverna cverna added this to To do in CI Gating via automation Sep 5, 2019
@cverna cverna moved this from To do to Ready in CI Gating Sep 9, 2019
@ryanlerch ryanlerch moved this from Ready to In progress in CI Gating Sep 26, 2019
ryanlerch added a commit to ryanlerch/bodhi that referenced this issue Sep 26, 2019
When creating a new update from a side tag, each of the
builds in the update are tagged in koji with
<sidetag>-pending-signing. However, when editing an update,
updated builds were trying to be signed with the regular
pending signing tag for the release (rather than the sidetag tags)

This commit now signs the builds with the correct sidetag koji tag
when editing a sidetag update.

fixes: fedora-infra#3485
Signed-off-by: Ryan Lerch <rlerch@redhat.com>
@ryanlerch ryanlerch moved this from In progress to Need Review in CI Gating Sep 26, 2019
@mergify mergify bot closed this in #3520 Sep 26, 2019
CI Gating automation moved this from Need Review to Merged to develop Sep 26, 2019
mergify bot added a commit that referenced this issue Sep 26, 2019
When creating a new update from a side tag, each of the
builds in the update are tagged in koji with
<sidetag>-pending-signing. However, when editing an update,
updated builds were trying to be signed with the regular
pending signing tag for the release (rather than the sidetag tags)

This commit now signs the builds with the correct sidetag koji tag
when editing a sidetag update.

fixes: #3485
Signed-off-by: Ryan Lerch <rlerch@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
CI Gating
  
Merged to develop
2 participants
You can’t perform that action at this time.