Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment and close bugs in same operation #404

Closed
AdamWill opened this issue Aug 27, 2015 · 1 comment · Fixed by #851

Comments

@AdamWill
Copy link
Contributor

commented Aug 27, 2015

It looks like Bodhi 2.0 is performing two separate Bugzilla transactions when closing bugs: first it writes the "has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report." message, then it sends another request to close the bug. This results in two Bugzilla mails to everyone subscribed to the bug. It'd be better if it used one transaction both to post the comment and close the bug (only in the case where 'close bugs when update pushed stable' is set, of course).

@ralphbean ralphbean added the bugzilla label Sep 1, 2015

@bowlofeggs

This comment has been minimized.

Copy link
Member

commented Jun 14, 2016

I'm going to work on this one as my first "real" Bodhi commit, because it sounds doable and it annoys me too ☺

bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue Jun 14, 2016
Bundle Bugzilla comments with the close command.
Bodhi used to add a comment to a Bugzilla that the ticket was
resolved, and then close it in a separate transation. This commit
adjusts Bodhi to close and comment in the same Bugzilla transaction
to reduce the number of e-mails that users receive.

closes fedora-infra#404
bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue Jun 15, 2016
Bundle Bugzilla comments with the close command.
Bodhi used to add a comment to a Bugzilla that the ticket was
resolved, and then close it in a separate transation. This commit
adjusts Bodhi to close and comment in the same Bugzilla transaction
to reduce the number of e-mails that users receive.

closes fedora-infra#404
bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue Jun 15, 2016
Bundle Bugzilla comments with the close command.
Bodhi used to add a comment to a Bugzilla that the ticket was
resolved, and then close it in a separate transation. This commit
adjusts Bodhi to close and comment in the same Bugzilla transaction
to reduce the number of e-mails that users receive.

closes fedora-infra#404
bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue Jun 15, 2016
Bundle Bugzilla comments with the close command.
Bodhi used to add a comment to a Bugzilla that the ticket was
resolved, and then close it in a separate transation. This commit
adjusts Bodhi to close and comment in the same Bugzilla transaction
to reduce the number of e-mails that users receive.

closes fedora-infra#404
bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue Jun 15, 2016
Bundle Bugzilla comments with the close command.
Bodhi used to add a comment to a Bugzilla that the ticket was
resolved, and then close it in a separate transation. This commit
adjusts Bodhi to close and comment in the same Bugzilla transaction
to reduce the number of e-mails that users receive.

closes fedora-infra#404

@lmacken lmacken closed this in #851 Jul 6, 2016

trishnaguha pushed a commit to trishnaguha/bodhi that referenced this issue Aug 29, 2016
Bundle Bugzilla comments with the close command.
Bodhi used to add a comment to a Bugzilla that the ticket was
resolved, and then close it in a separate transation. This commit
adjusts Bodhi to close and comment in the same Bugzilla transaction
to reduce the number of e-mails that users receive.

closes fedora-infra#404
amolkahat added a commit to amolkahat/bodhi that referenced this issue Feb 2, 2017
Bundle Bugzilla comments with the close command.
Bodhi used to add a comment to a Bugzilla that the ticket was
resolved, and then close it in a separate transation. This commit
adjusts Bodhi to close and comment in the same Bugzilla transaction
to reduce the number of e-mails that users receive.

closes fedora-infra#404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.