Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable automatic karma push when there is any negative karma #833

Closed
kparal opened this issue Apr 25, 2016 · 1 comment

Comments

@kparal
Copy link
Contributor

commented Apr 25, 2016

We sometimes have updates in which many people give +1 because they see no issue, but as many people give -1 because they see a serious issue. Like this one, when translations broke for non-english speaking users:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-feb00cca4b

The problem is that at some point the amount if +1 votes can reach the auto karma push threshold and the whole update is going to get pushed to stable, even though there are many many -1 votes for that update as well and it should definitely not go stable, at least automatically. This happens randomly, as different people test this (it can easily happen that the first two people have an issue and give it -1, then five users give it +1 "works for me", and before another affected user can give it -1, it's already scheduled for stable and we can't do anything about it).

If the maintainer doesn't watch this update closely and doesn't react in time (maintainers sometimes also sleep), we end up with broken software shipping to all our users. In my QA experience I've seen this happen repeatedly, sometimes trying to reach to a maintainer to not succeeding in time, sometimes seeing this after it happened.

Please let's fix this. I believe that once a -1 karma is given to a particular update, it should disable auto karma push. The unpush value can stay the same (it still makes sense to unpush an update automatically when many people report issues), but the push stable value should be reset to 0 (or whatever value means "disabled"). In other words, once we received a failure report, we should never push software automatically to all our users, it should always be a conscious decision of the package maintainer. It would be nice it this change was reflected inside the update (e.g. added a new bodhi comment Negative karma received, disabling automatic push to stable. Please push manually if you decide the issue is not severe.).

A nice final touch would be to re-enable push to stable if all users who gave -1 karma amended their vote and changed it to +1 (i.e. there was some confusion and it was cleared). However, that's probably more difficult to implement; a basic implementation as described above would be completely sufficient and would improve quality of Fedora updates quite a bit.

Thanks a lot.

@kparal

This comment has been minimized.

Copy link
Contributor Author

commented Feb 16, 2017

Fixed in #1191.

@kparal kparal closed this Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.