Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize locations of client and server code #900

Closed
bowlofeggs opened this issue Sep 1, 2016 · 2 comments · Fixed by #904 or #915

Comments

@bowlofeggs
Copy link
Member

commented Sep 1, 2016

Since the client and server code typically gets split into two different RPMs during packaging, it would be easier to separate them if they were more cleanly separated in our git repository. Something simple like moving them into bodhi/client/ and bodhi/server/ would make it a little easier to keep them separate in the spec file. Alternatively, we could create two separate Python packages for the client at server at the top level in this repository, or even start a new git repository for the bodhi client.

@bowlofeggs bowlofeggs added the RFE label Sep 1, 2016

@bowlofeggs bowlofeggs referenced this issue Sep 2, 2016
7 of 7 tasks complete
@bowlofeggs

This comment has been minimized.

Copy link
Member Author

commented Sep 2, 2016

I've been working on updating the bodhi package in Rawhide, and I've hit a problem where the bodhi-client package depended on the bodhi-server package. I attempted to resolve this by creating a new python2-bodhi package to own the bodhi/__init__.py file, but unfortunately I then discovered that the init file contains server code. Due to this, I have decided to formally split the server and client code now so we have a clear separation between them.

Thus, this task is needed for #142.

@bowlofeggs bowlofeggs self-assigned this Sep 2, 2016

@bowlofeggs bowlofeggs added this to the 2.2.0 milestone Sep 2, 2016

@bowlofeggs

This comment has been minimized.

Copy link
Member Author

commented Sep 2, 2016

@bowlofeggs bowlofeggs added the Critical label Sep 2, 2016

bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue Sep 3, 2016
Cleanly separate client and server code.
Prior to this commit, it was impossible to install the Bodhi client
separately from the server, as the bodhi.__init__ module contained
server code. This commit creates new bodhi.client and bodhi.server
modules so there is a clear separation between them. This will help
future developers keep them apart mentally, and it will make
packaging Bodhi simpler.

fixes fedora-infra#900

@bowlofeggs bowlofeggs reopened this Sep 9, 2016

bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue Sep 9, 2016
bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue Sep 9, 2016
bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue Sep 9, 2016
bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue Sep 9, 2016
bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue Sep 9, 2016
amolkahat added a commit to amolkahat/bodhi that referenced this issue Feb 2, 2017
Cleanly separate client and server code.
Prior to this commit, it was impossible to install the Bodhi client
separately from the server, as the bodhi.__init__ module contained
server code. This commit creates new bodhi.client and bodhi.server
modules so there is a clear separation between them. This will help
future developers keep them apart mentally, and it will make
packaging Bodhi simpler.

fixes fedora-infra#900
amolkahat added a commit to amolkahat/bodhi that referenced this issue Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.