Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around missing repodata.xml #908

Closed
bowlofeggs opened this issue Sep 6, 2016 · 25 comments · Fixed by #1147

Comments

@bowlofeggs
Copy link
Member

commented Sep 6, 2016

Sometimes the previous run of the Bodhi masher leaves some directories with missing repodata.xml files (See #887). That issue is about stopping that from happening in the future, but it is a bit mysterious and may take some time to identify its cause.

In the meantime, we can make Bodhi more robust. In subsequent runs of the masher, there is a test for the existence of the folder that should contain a repodata.xml file and if that folder is present Bodhi assumes that the file is present as well. This assumption is false, and it causes Bodhi to blow up later.

We should adjust that test to test for the existence of the file instead of the folder. This will make Bodhi more robust for releng, and should be a pretty easy change as well.

@amitsin6h

This comment has been minimized.

Copy link

commented Sep 9, 2016

can i work on this

@bowlofeggs

This comment has been minimized.

Copy link
Member Author

commented Sep 9, 2016

@amitsin6h sure, that would be great!

@amitsin6h

This comment has been minimized.

Copy link

commented Sep 9, 2016

so how can i start. excited \o/

@bowlofeggs

This comment has been minimized.

Copy link
Member Author

commented Sep 9, 2016

Hey @amitsin6h! The easiest way to get start with Bodhi development is to use our Vagrant setup:

https://github.com/fedora-infra/bodhi/blob/develop/README.rst#vagrant

I'm not actually too familiar with the specific code that this ticket is about, so I'm not sure I can give you very specific pointers for it. I marked it easy fix because once you find that if statement (wherever it is), it's likely just a matter of adjusting the check to test for the existence of the file rather than the directory that contains it.

@himanshuraja

This comment has been minimized.

Copy link

commented Sep 9, 2016

hello,can I also work on it?

@bowlofeggs

This comment has been minimized.

Copy link
Member Author

commented Sep 9, 2016

Hello @himanshuraja! This is probably going to be a pretty small change, but if you want to coordinate with @amitsin6h go for it!

@himanshuraja

This comment has been minimized.

Copy link

commented Sep 9, 2016

Yes but I am new to this , can you please help me out in starting ? Thank you .

Sent from my iPhone

On 10-Sep-2016, at 3:22 AM, Randy Barlow notifications@github.com wrote:

Hello @himanshuraja! This is probably going to be a pretty small change, but if you want to coordinate with @amitsin6h go for it!


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@himanshuraja

This comment has been minimized.

Copy link

commented Sep 10, 2016

thanks a lot @trishnaguha .

@himanshuraja

This comment has been minimized.

@sayanchowdhury

This comment has been minimized.

Copy link
Member

commented Sep 10, 2016

@himanshuraja It would be better to come over on IRC for any issues you are facing.

@himanshuraja

This comment has been minimized.

Copy link

commented Sep 10, 2016

Hi,
I am new to contributing,can you please share the channel where I can log
on.
Thanks.
Regards,
Himanshu Sharma
dgplug,Acadgild

On Sat, Sep 10, 2016 at 5:46 PM, Sayan Chowdhury notifications@github.com
wrote:

@himanshuraja https://github.com/himanshuraja It would be better to
come over on IRC for any issues you are facing.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#908 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJAt1tgb23qZBtcVvSBojSgdY1FNxk3-ks5qop-PgaJpZM4J2H5-
.

@sayanchowdhury

This comment has been minimized.

Copy link
Member

commented Sep 10, 2016

The channel is #fedora-apps on Freenode.

@himanshuraja

This comment has been minimized.

Copy link

commented Sep 10, 2016

I really appreciate it,thank you.

@amitsin6h

This comment has been minimized.

Copy link

commented Sep 12, 2016

am having problem in setting up bodhi development am setting up using virtualenv

@k3rn3l3rr0r

This comment has been minimized.

Copy link
Contributor

commented Sep 12, 2016

@amitsin6h Can you describe the problem further? Maybe include the error message or a link to a log?

@k3rn3l3rr0r

This comment has been minimized.

Copy link
Contributor

commented Sep 12, 2016

@amitsin6h @bowlofeggs I can't test it right now on virtualenv host, but it seems like a deps/path problem coming from link_system_libs() in the bootstrap.py ... This conversation should be moved in new, separate issue.

@bowlofeggs

This comment has been minimized.

Copy link
Member Author

commented Sep 12, 2016

@amitsin6h it looks to me like maybe you don't have a virtuenv enabled.

@amitsin6h

This comment has been minimized.

Copy link

commented Sep 12, 2016

@bowlofeggs how should i enable it

@bowlofeggs

This comment has been minimized.

Copy link
Member Author

commented Sep 12, 2016

@amitsin6h I'm not sure, but it does sound like there might be a problem in the virtualenv setup. I agree with @k3rn3l3rr0r, and recommend filing a separate issue as we don't want to fill this ticket up with non-related conversation.

k3rn3l3rr0r added a commit to k3rn3l3rr0r/bodhi that referenced this issue Sep 12, 2016
k3rn3l3rr0r added a commit to k3rn3l3rr0r/bodhi that referenced this issue Sep 12, 2016
@amitsin6h

This comment has been minimized.

Copy link

commented Sep 14, 2016

@bowlofeggs is this the thing which i need to fix
http://paste.fedoraproject.org/427822/82777114/

@trishnaguha

This comment has been minimized.

Copy link
Contributor

commented Sep 14, 2016

@k3rn3l3rr0r Make sure to open PR since you have already committed in your fork :).

@k3rn3l3rr0r

This comment has been minimized.

Copy link
Contributor

commented Sep 14, 2016

@trishnaguha Thanks. But I commented on that diff and pinged @bowlofeggs to take a look, as I wasn't very sure, this could be merged... But yeah, I will open a PR.

@bowlofeggs

This comment has been minimized.

Copy link
Member Author

commented Sep 14, 2016

@amitsin6h It looks like you have a missing dependency. I think @k3rn3l3rr0r might have made the change we need in that linked PR. @k3rn3l3rr0r, I'll take a look soon and thanks very much!

@bowlofeggs bowlofeggs removed this from the 2.3 milestone Oct 28, 2016

@bowlofeggs bowlofeggs self-assigned this Dec 8, 2016

bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue Dec 8, 2016
bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue Dec 8, 2016
Add a test that missing repomd.xml files won't crash masher.
This commit contains a test for the commit that fixes fedora-infra#908.
bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue Dec 9, 2016
bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue Dec 9, 2016
Add a test that missing repomd.xml files won't crash masher.
This commit contains a test for the commit that fixes fedora-infra#908.
amolkahat added a commit to amolkahat/bodhi that referenced this issue Feb 2, 2017
amolkahat added a commit to amolkahat/bodhi that referenced this issue Feb 2, 2017
Add a test that missing repomd.xml files won't crash masher.
This commit contains a test for the commit that fixes fedora-infra#908.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.