Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bodhi 2.2.0 does not display the lock banner on locked updates during pushes anymore #952

Closed
bowlofeggs opened this issue Sep 21, 2016 · 4 comments

Comments

@bowlofeggs
Copy link
Member

commented Sep 21, 2016

These two updates should both display that they are locked right now because there is an active push for them in progress, but neither of them displays the locked banner:

https://bodhi.fedoraproject.org/updates/FEDORA-2016-a6867138e2
https://bodhi.fedoraproject.org/updates/FEDORA-2016-821d2ec8cd

@bowlofeggs

This comment has been minimized.

Copy link
Member Author

commented Sep 21, 2016

@puiterwijk suggested that the problem is that the update.locked = True isn't followed by session.add(update) at https://github.com/fedora-infra/bodhi/blob/2.2.0/bodhi/server/consumers/masher.py#L220

bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue Sep 22, 2016
@trishnaguha

This comment has been minimized.

Copy link
Contributor

commented Sep 22, 2016

This also means we don't have test for this :(.

@puiterwijk

This comment has been minimized.

Copy link
Member

commented Sep 22, 2016

Turns out that we WERE locking them, but the interface didn't get the massive banner because of date_locked not being set.
See #959 and its commit messages for the explanation.

@bowlofeggs

This comment has been minimized.

Copy link
Member Author

commented Sep 22, 2016

Thanks @puiterwijk! I'll update the text here to reflect that.

@bowlofeggs bowlofeggs changed the title Bodhi 2.2.0 does not seem to lock updates during pushes anymore Bodhi 2.2.0 does not display the lock banner on locked updates during pushes anymore Sep 22, 2016

puiterwijk added a commit that referenced this issue Sep 22, 2016
More .server entries
Fixes: #952
Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue Sep 22, 2016
Register the date of locking at the same time as locking
This will make sure that the banner in the interface will get displayed
to warn people that the update is locked.

Fixes: fedora-infra#952
Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
amolkahat added a commit to amolkahat/bodhi that referenced this issue Feb 2, 2017
Register the date of locking at the same time as locking
This will make sure that the banner in the interface will get displayed
to warn people that the update is locked.

Fixes: fedora-infra#952
Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.