Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Further comments on pushed updates with autopush disabled remove stable requests #989
Andre Robatino reported that Bodhi update stable requests are being reset by subsequent comments. For example, this kernel update was set to go to stable by labbott about 15 hours ago at the time of this writing. About 8 hours after that, another user helpfully gave the update a +1 and that comment caused the request for stable to be removed. The update now shows as status testing with no request.
I have not yet investigated the code to determine where the mistake in logic is.
If you experience this issue on one of your updates, a possible workaround is to edit the update and turn autokarma on. After doing this, any additional +1 should trigger the update to push. You should also be able to push the update once it reaches 7 days.
This is easily reproducible in staging:
Which theoretically means it shouldn't be hard to fix!
The problem is in this code:
This code causes any comment with karma on a non-autopushing update to set self.request to