Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further comments on pushed updates with autopush disabled remove stable requests #989

Closed
bowlofeggs opened this issue Sep 30, 2016 · 3 comments · Fixed by #992

Comments

@bowlofeggs
Copy link
Member

commented Sep 30, 2016

Andre Robatino reported that Bodhi update stable requests are being reset by subsequent comments. For example, this kernel update was set to go to stable by labbott about 15 hours ago at the time of this writing. About 8 hours after that, another user helpfully gave the update a +1 and that comment caused the request for stable to be removed. The update now shows as status testing with no request.

I have not yet investigated the code to determine where the mistake in logic is.

Known workaround

If you experience this issue on one of your updates, a possible workaround is to edit the update and turn autokarma on. After doing this, any additional +1 should trigger the update to push. You should also be able to push the update once it reaches 7 days.

@bowlofeggs bowlofeggs added the Critical label Sep 30, 2016

@bowlofeggs bowlofeggs self-assigned this Sep 30, 2016

@bowlofeggs bowlofeggs added High priority and removed Critical labels Sep 30, 2016

@bowlofeggs

This comment has been minimized.

Copy link
Member Author

commented Sep 30, 2016

I've lowered the priority due to discovering a workaround.

@bowlofeggs

This comment has been minimized.

Copy link
Member Author

commented Sep 30, 2016

This is easily reproducible in staging:

https://bodhi.stg.fedoraproject.org/updates/FEDORA-2016-7179af3ac1

Which theoretically means it shouldn't be hard to fix!

@bowlofeggs

This comment has been minimized.

Copy link
Member Author

commented Sep 30, 2016

The problem is in this code:

                    if self.autokarma:
                        log.info("Automatically marking %s as stable" % self.title)
                        self.set_request(db, UpdateRequest.stable, agent)
                        self.request = UpdateRequest.stable
                        self.date_pushed = None
                        notifications.publish(
                            topic='update.karma.threshold.reach',
                            msg=dict(update=self, status='stable'))
                    else:
                        # Add the 'testing_approval_msg_based_on_karma' message now
                        log.info("%s update has reached the stable karma threshold and can be pushed to "\
                        "stable now if the maintainer wishes" % self.title)
                         self.request = None

This code causes any comment with karma on a non-autopushing update to set self.request to None, regardless of what the request is.

bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue Oct 3, 2016
bowlofeggs added a commit that referenced this issue Oct 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.