Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result != results #1072

Merged
merged 1 commit into from Nov 2, 2016

Conversation

@puiterwijk
Copy link
Member

commented Oct 28, 2016

Signed-off-by: Patrick Uiterwijk puiterwijk@redhat.com

Result != results
Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
@bowlofeggs
Copy link
Member

left a comment

I wish we had test coverage for this ☹

@pypingou

This comment has been minimized.

Copy link
Member

commented Oct 28, 2016

👍 as well, but indeed no tests :(

@bowlofeggs

This comment has been minimized.

Copy link
Member

commented Oct 28, 2016

@pypingou I'm going to allow this one in without tests because we are checking it live on production (really, ooof!). However, I do have a task warrior recurring task to increase bodhi's test coverage slowly to 100% over time, and I plan to require new code to be tested from now on.

Today is a bit of a special case because I want to make a bodh-2.3.2 quickly since production is broken. We are making sure this works by hotfixing production and then committing those changes here. Definitely not best practice, but I don't have much time to get production fixed before the weekend so I think it's allowable in this circumstance.

Also, technically I haven't merged the PR that requires test coverage yet ☺

@bowlofeggs bowlofeggs added this to the Bodhi 2.3.2 milestone Oct 28, 2016

@bowlofeggs bowlofeggs merged commit 9762477 into develop Nov 2, 2016

@bowlofeggs bowlofeggs deleted the fix-typo branch Nov 2, 2016

@bowlofeggs

This comment has been minimized.

Copy link
Member

commented Nov 2, 2016

I have cherry picked this one to the 2.3 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.