Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build docs without install #1359

Merged

Conversation

Projects
None yet
2 participants
@bowlofeggs
Copy link
Member

commented Mar 20, 2017

No description provided.

global bugtracker
if config.get('bugtracker') == 'bugzilla':
log.info('Using python-bugzilla')
bugtracker = Bugzilla()

This comment has been minimized.

Copy link
@pypingou

pypingou Mar 21, 2017

Member

Should we check if it has been instantiated before?

This comment has been minimized.

Copy link
@bowlofeggs

bowlofeggs Mar 21, 2017

Author Member

@pypingou We could do that, but I don't believe there would be harm in replacing it. If that happened, the old one would get garbage collected and things would keep on working.

@@ -36,7 +36,7 @@

import fedmsg.consumers

from bodhi.server.bugs import bugtracker
from bodhi.server import bugs as bug_module

This comment has been minimized.

Copy link
@pypingou

pypingou Mar 21, 2017

Member

For the other modules you just import bugs, do we want to be consistent there?

This comment has been minimized.

Copy link
@bowlofeggs

bowlofeggs Mar 21, 2017

Author Member

@pypingou I did this because there are already variables used in this module called bugs, and it was easier to import this under a different name than to rename all those variables. The variables actually have a more natural usage anyway (such as for bug in bugs) and the bugs module isn't so natural (it doesn't actually contain bugs, it just has a class that can help you query bugzilla.)

@pypingou

This comment has been minimized.

Copy link
Member

commented Mar 21, 2017

Couple of question but nothing blocking for me, 👍

bowlofeggs added some commits Mar 20, 2017

PEP-8 an import statement.
Signed-off-by: Randy Barlow <randy@electronsweatshop.com>
Initialize the bugtracker in main() instead of on import.
Before this commit, it was not possible to build the documentation
without installing Bodhi first, since importing bodhi.server would
cause the config to get loaded which would cause a exception when
it could not find the bodhi-server distribution. With this patch,
it is possible to import Bodhi's server code without installing
Bodhi.

Signed-off-by: Randy Barlow <randy@electronsweatshop.com>

@bowlofeggs bowlofeggs force-pushed the bowlofeggs:build_docs_without_install branch from 1f7651f to 99b1183 Mar 21, 2017

@bowlofeggs bowlofeggs merged commit 99b1183 into fedora-infra:develop Mar 21, 2017

@bowlofeggs bowlofeggs deleted the bowlofeggs:build_docs_without_install branch Mar 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.