Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type and name fixes #3320

Merged
merged 4 commits into from Jun 18, 2019

Conversation

2 participants
@nphilipp
Copy link
Member

commented Jun 17, 2019

This PR contains the commits that fix type names and make validator names less ambiguous which are required, but not topical to PR#3228.

nphilipp added some commits May 8, 2019

Correct location of request type.
We refer to the type of requests in a couple of places, in docstrings
and type hints, the Request class has been moved from pyramid.util to
pyramid.request.

Signed-off-by: Nils Philippsen <nils@redhat.com>
Don't mention obsolete string types.
String handling has changed from Python 2 to 3, use the up to date type
names.

Signed-off-by: Nils Philippsen <nils@redhat.com>
Use less ambiguous validator names.
The names validate_nvrs and validate_uniqueness alone don't tell users
that they concern the supplied builds.

Signed-off-by: Nils Philippsen <nils@redhat.com>

@nphilipp nphilipp requested a review from fedora-infra/bodhi as a code owner Jun 17, 2019

@nphilipp nphilipp added this to To do in CI Gating via automation Jun 17, 2019

@nphilipp nphilipp moved this from To do to Need Review in CI Gating Jun 17, 2019

@nphilipp nphilipp added the EasyFix label Jun 17, 2019

@cverna

cverna approved these changes Jun 18, 2019

Copy link
Member

left a comment

LGTM, thanks

@mergify mergify bot merged commit 934baa3 into fedora-infra:develop Jun 18, 2019

30 of 32 checks passed

continuous-integration/jenkins/pr-head This commit is being built
Details
rawhide-integration running
Details
DCO DCO
Details
Rule: default (merge) The pull request has been merged automatically
Details
Rule: default-from-bowlofeggs (merge) Another merge action already ran
Details
Summary 2 rules match and 4 potential rules
Details
f29-build
Details
f29-diff-cover
Details
f29-docs
Details
f29-integration
Details
f29-integration-build
Details
f29-unit
Details
f30-build
Details
f30-diff-cover
Details
f30-docs
Details
f30-integration
Details
f30-integration-build
Details
f30-unit
Details
pip-build
Details
pip-diff-cover
Details
pip-docs
Details
pip-flake8
Details
pip-integration
Details
pip-integration-build
Details
pip-mypy
Details
pip-pydocstyle
Details
pip-unit
Details
rawhide-build
Details
rawhide-diff-cover
Details
rawhide-docs
Details
rawhide-integration-build
Details
rawhide-unit
Details

CI Gating automation moved this from Need Review to Merged to develop Jun 18, 2019

@nphilipp nphilipp deleted the nphilipp:develop--type-and-name-fixes branch Jun 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.