Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout flag to pytest #3363

Closed

Conversation

sebwoj
Copy link
Collaborator

@sebwoj sebwoj commented Jun 29, 2019

fix #3339

Signed-off-by: Sebastian Wojciechowski s.wojciechowski89@gmail.com

@sebwoj sebwoj requested a review from a team as a code owner June 29, 2019 11:32
@sebwoj sebwoj force-pushed the Add_timeout_flag_to_pytest branch 3 times, most recently from 67a8896 to fe3d17b Compare June 29, 2019 15:19
@sebwoj
Copy link
Collaborator Author

sebwoj commented Jun 29, 2019

At first, I inserted "--timeout=60" to this config file, but I have no idea how to install pytest-timeoout in CI enviroment. This is why this cli option is in every pytest invocation, except for CI.

Copy link
Member

@abompard abompard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To add pytest-timeout to CI, you need to add it to the installed packages in devel/ci/cico.pipeline (look for pytest there).
Also, I think it would be better to add the CLI option to setup.cfg, where options are already added to the command line.

@sebwoj sebwoj force-pushed the Add_timeout_flag_to_pytest branch from fe3d17b to cde66f9 Compare July 2, 2019 19:15
@sebwoj
Copy link
Collaborator Author

sebwoj commented Jul 2, 2019

Yeah, this is the place I was looking for.
Thx @abompard

@ryanlerch
Copy link
Collaborator

@sebwoj just one conflict on this one.

@abompard is your change request satisfied now too?

@sebwoj sebwoj force-pushed the Add_timeout_flag_to_pytest branch 2 times, most recently from 8b0be3f to 5c1d641 Compare November 5, 2019 11:10
fix fedora-infra#3339

Signed-off-by: Sebastian Wojciechowski <s.wojciechowski89@gmail.com>
@sebwoj
Copy link
Collaborator Author

sebwoj commented Nov 5, 2019

@abompard It looks like integration tests are still missing pytest-timeout.

In the PR I wrote the following command:
'python3.6 -m pip install \'pytest<4.0\' pytest-cov conu munch fedora-messaging pytest-timeout'
but in CI(jenkins console ) the following command is performed:
'python3.6 -m pip install '\''pytest<4.0'\'' pytest-cov conu munch fedora-messaging'
Do you know how to fix this?

@cverna
Copy link
Contributor

cverna commented May 8, 2020

Closing this due to inactivity

@cverna cverna closed this May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get tests to fail if they take too long
6 participants