Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ChartJS and redesign Release page. #3671

Merged
merged 4 commits into from Nov 4, 2019

Conversation

@mattiaverga
Copy link
Contributor

mattiaverga commented Oct 29, 2019

  • Update ChartJS
  • Move the timeline graph on the right column, so that it is wider and more readable
  • Add a color for "enhancement" type to distinguish it from "unspecified" type; also add a test for type2color() which wasn't tested at all
  • Split tables in the left column, add captions, show all the properties of the release like the CLI output
  • Add two new graphs (updates by type and updates by status) and fix links and icons not being showed
  • Lastly, add a placeholder in case Javascript is disabled.

immagine

Signed-off-by: Mattia Verga mattia.verga@tiscali.it

Signed-off-by: Mattia Verga <mattia.verga@tiscali.it>
@mattiaverga mattiaverga force-pushed the mattiaverga:release_page branch from 76531ce to 4bff510 Oct 29, 2019
@mattiaverga mattiaverga marked this pull request as ready for review Oct 29, 2019
@mattiaverga mattiaverga requested a review from fedora-infra/bodhi as a code owner Oct 29, 2019
@ryanlerch ryanlerch self-requested a review Oct 30, 2019
Copy link
Contributor

ryanlerch left a comment

Thanks!

This was the one i kinda left alone, thanks for the refresh!

LGTM

pypingou added 2 commits Nov 4, 2019
Copy link
Member

pypingou left a comment

If @ryanlerch is fine, so am I :)

@mergify mergify bot merged commit 5592ec4 into fedora-infra:develop Nov 4, 2019
34 of 36 checks passed
34 of 36 checks passed
continuous-integration/jenkins/pr-head This commit is being built
Details
rawhide-integration running
Details
DCO DCO
Details
Summary 1 rule matches and 6 potential rules
Details
f29-build
Details
f29-diff-cover
Details
f29-docs
Details
f29-integration
Details
f29-integration-build
Details
f29-unit
Details
f30-build
Details
f30-diff-cover
Details
f30-docs
Details
f30-integration
Details
f30-integration-build
Details
f30-unit
Details
f31-build
Details
f31-diff-cover
Details
f31-docs
Details
f31-integration
Details
f31-integration-build
Details
f31-unit
Details
pip-build
Details
pip-diff-cover
Details
pip-docs
Details
pip-flake8
Details
pip-integration
Details
pip-integration-build
Details
pip-mypy
Details
pip-pydocstyle
Details
pip-unit
Details
rawhide-build
Details
rawhide-diff-cover
Details
rawhide-docs
Details
rawhide-integration-build
Details
rawhide-unit
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.