Skip to content

Frontend: produce combined gating status from all queries (#4320)#4784

Merged
mergify[bot] merged 1 commit intofedora-infra:developfrom
AdamWill:gating-status-combined
Oct 31, 2022
Merged

Frontend: produce combined gating status from all queries (#4320)#4784
mergify[bot] merged 1 commit intofedora-infra:developfrom
AdamWill:gating-status-combined

Conversation

@AdamWill
Copy link
Copy Markdown
Contributor

Instead of showing one gating status per greenwave request, which users find very confusing, keep track of requirement counts as we run through the queries, then generate a single combined gating status at the end.

Signed-off-by: Adam Williamson awilliam@redhat.com

@AdamWill AdamWill requested a review from a team as a code owner October 13, 2022 15:35
@AdamWill
Copy link
Copy Markdown
Contributor Author

I've tested this locally (after spending three and a half hours getting a Bodhi instance running sufficiently well to test it...) and it seems to work pretty well. Just compare the results on e.g. https://bodhi.fedoraproject.org/updates/FEDORA-2022-a895955321 with and without this patch. I did test it on updates that have failed gating, e.g. https://bodhi.fedoraproject.org/updates/FEDORA-2022-3c52402aec , to check that its results look correct.

Note we have the places where the gating status is shown - under TEST GATING on the main page, and near the top of the Automated Tests tab - show the update's TestGatingStatus until all the greenwave queries are done, when it gets replaced with the more detailed calculated summary. This means on updates where running all the greenwave queries takes a long time, you do at least get some information there immediately.

@AdamWill
Copy link
Copy Markdown
Contributor Author

Before:

Screenshot from 2022-10-13 17-41-48

After:

Screenshot from 2022-10-13 17-42-49

Copy link
Copy Markdown
Contributor

@mattiaverga mattiaverga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rebased on top of the recent template migration, can you add a note for the release notes?

…ra#4320)

Instead of showing one gating status per greenwave request,
which users find very confusing, keep track of requirement counts
as we run through the queries, then generate a single combined
gating status at the end.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
@AdamWill AdamWill force-pushed the gating-status-combined branch from c015d93 to 281e1d4 Compare October 30, 2022 16:35
@AdamWill
Copy link
Copy Markdown
Contributor Author

Huh, tests are failing on a Rawhide dependency issue, it seems. I'll see if I can fix that later.

@mattiaverga
Copy link
Copy Markdown
Contributor

Don't worry about failing tests in rawhide, it is due to https://bugzilla.redhat.com/show_bug.cgi?id=2138636

@AdamWill
Copy link
Copy Markdown
Contributor Author

I know, I was actually working on it already but had to go out. I filed the issue upstream, I wasn't just going to hack it downstream.

@mergify mergify Bot merged commit 37c57e1 into fedora-infra:develop Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants