Frontend: produce combined gating status from all queries (#4320)#4784
Conversation
|
I've tested this locally (after spending three and a half hours getting a Bodhi instance running sufficiently well to test it...) and it seems to work pretty well. Just compare the results on e.g. https://bodhi.fedoraproject.org/updates/FEDORA-2022-a895955321 with and without this patch. I did test it on updates that have failed gating, e.g. https://bodhi.fedoraproject.org/updates/FEDORA-2022-3c52402aec , to check that its results look correct. Note we have the places where the gating status is shown - under TEST GATING on the main page, and near the top of the Automated Tests tab - show the update's |
736af62 to
fee14e7
Compare
fee14e7 to
a0f1154
Compare
a0f1154 to
c015d93
Compare
mattiaverga
left a comment
There was a problem hiding this comment.
I've rebased on top of the recent template migration, can you add a note for the release notes?
…ra#4320) Instead of showing one gating status per greenwave request, which users find very confusing, keep track of requirement counts as we run through the queries, then generate a single combined gating status at the end. Signed-off-by: Adam Williamson <awilliam@redhat.com>
c015d93 to
281e1d4
Compare
|
Huh, tests are failing on a Rawhide dependency issue, it seems. I'll see if I can fix that later. |
|
Don't worry about failing tests in rawhide, it is due to https://bugzilla.redhat.com/show_bug.cgi?id=2138636 |
|
I know, I was actually working on it already but had to go out. I filed the issue upstream, I wasn't just going to hack it downstream. |


Instead of showing one gating status per greenwave request, which users find very confusing, keep track of requirement counts as we run through the queries, then generate a single combined gating status at the end.
Signed-off-by: Adam Williamson awilliam@redhat.com